Liron Ar has posted comments on this change. Change subject: engine: Speed up SPM re-selection process. ......................................................................
Patch Set 1: The issue was introduced in commit http://gerrit.ovirt.org/#/c/15345/ that changed the getAllTasksStatuses to be an spm command, therefore an error is raised. I think that it should be fixed inside SpmStopVdsCommand (as it currently procces the result of getAllTaskStatuses) to unify the behaviour, currently if this error return from spmStop we will perform X and when it returns from getAllTasksStatus we perform Y - that's confusing. -- To view, visit http://gerrit.ovirt.org/18013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c191ad8d4ec0fb4f5f8ff68b84fa5189ecc7114 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
