Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: use ssh public key for allinone
......................................................................


Patch Set 10:

(2 comments)

....................................................
File ovirt-engine.spec.in
Line 390: 
Line 391: %package setup-plugin-allinone
Line 392: Summary: All-in-one plugin for %{product_name_short}'s setup
Line 393: Group: Virtualization/Management
Line 394: Requires: %{name}-setup
right but need to get version when we finally have one that is working.
Line 395: Requires: %{name}-sdk >= 3.1.0.6
Line 396: Requires: openssh-server
Line 397: Requires: ovirt-host-deploy >= 1.1.0
Line 398: Requires: ovirt-host-deploy-offline >= 1.1.0


....................................................
File packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py
Line 113:                 filetransaction.FileTransaction(
Line 114:                     name=authorized_keys_file,
Line 115:                     content=content,
Line 116:                     mode=0o600,
Line 117:                     
owner=self.environment[osetupcons.SystemEnv.USER_ROOT],
right... this should be hardcoded to root... has no customization, as not 
working in devenv anyway.
Line 118:                     enforcePermissions=True,
Line 119:                     modifiedList=self.environment[
Line 120:                         otopicons.CoreEnv.MODIFIED_FILES
Line 121:                     ],


-- 
To view, visit http://gerrit.ovirt.org/17996
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I885894bba4c998e5dd3e9b2fd4da61d833f7a3a1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to