Tal Nisan has posted comments on this change.
Change subject: core: Remove member init in the query parameters
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListByStoragePoolIdParameters.java
Line 6: public class GetImagesListByStoragePoolIdParameters extends
GetImagesListParametersBase {
Line 7: private static final long serialVersionUID = 6098440434536241071L;
Line 8:
Line 9: public GetImagesListByStoragePoolIdParameters() {
Line 10: setStoragePoolId(Guid.Empty);
Doesn't matter much but any reason to go through the setter and not init
directly?
Line 11: }
Line 12:
Line 13: public GetImagesListByStoragePoolIdParameters(Guid storagePoolId) {
Line 14: setStoragePoolId(storagePoolId);
--
To view, visit http://gerrit.ovirt.org/18135
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic89595cd4e26b7fca901d62ba57f4cfdf29c12b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
