Daniel Erez has posted comments on this change. Change subject: frontend: pool dialog templates not updated accordint to DC ......................................................................
Patch Set 2: Code-Review+2 (3 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-08-15 13:55:14 +0200 Line 4: Commit: Tomas Jelinek <[email protected]> Line 5: CommitDate: 2013-08-15 14:41:52 +0200 Line 6: Line 7: frontend: pool dialog templates not updated accordint to DC s/accordint/according Line 8: Line 9: If the DC has been changed the templates have not been updated. Line 10: There were two issues which caused this: Line 11: Line 16: than other ListModelListBox. The ListModelListBox if gets a Line 17: value in setValue() which is not part of the acceptable values Line 18: adds it as one of them (in ValueListBox.updateListBox()). Line 19: The ListModelTypeAheadListBox have ignored this values as incorrect Line 20: ones. The problem is that UiCommonEditorVisitor firts calls the s/firts/first ? Line 21: setValue() and than the setAcceptableValues() which works correctly Line 22: only the first time. Fixed by aligning the ListModelTypeAheadListBox Line 23: to work the same as the ListModelListBox. Line 24: Line 17: value in setValue() which is not part of the acceptable values Line 18: adds it as one of them (in ValueListBox.updateListBox()). Line 19: The ListModelTypeAheadListBox have ignored this values as incorrect Line 20: ones. The problem is that UiCommonEditorVisitor firts calls the Line 21: setValue() and than the setAcceptableValues() which works correctly s/than/then Line 22: only the first time. Fixed by aligning the ListModelTypeAheadListBox Line 23: to work the same as the ListModelListBox. Line 24: Line 25: Bug-Url: https://bugzilla.redhat.com/987819 -- To view, visit http://gerrit.ovirt.org/18171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ab81ee7165f9855de3d843fcf7ead0fc3db512a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
