Allon Mureinik has submitted this change and it was merged. Change subject: core: Disable member init for GWT-compiled code ......................................................................
core: Disable member init for GWT-compiled code Following the upgrade of GWT(P), if an entity's constructor is not explicitly referenced in the UI code the inline member initializations are not taken into account in GWT's serialization policy [1]. This patch is the culmination of a series that suggests taking the safe route - instead of having the code (silently!) break if a call to the constructor is removed from the UI code, it simply disallows having such inline initializations. The previous patches in this set remove such initializers for various parts of the common and compat modules (broken up into smaller units for relative ease of review). This patch implements a checkstyle check to fail the build in compile time if such a dangerous initializer is introduced. [1] http://lists.ovirt.org/pipermail/engine-devel/2013-July/005256.html Change-Id: Iffd520ecb627e87254c4d325c85088179b0ef744 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M build-tools-root/checkstyles/src/main/resources/checkstyle.xml A build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoMemberInitializationCheck.java 4 files changed, 71 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffd520ecb627e87254c4d325c85088179b0ef744 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
