Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added network provider to Install Host
......................................................................
Patch Set 12:
(3 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 355:
Line 356: @DefaultStringValue("Password")
Line 357: String passwordQpid();
Line 358:
Line 359: @DefaultStringValue("External Network Provider")
Why did you move it from the ApplicationConstants.java?
Does the user-protal use these strings?
Line 360: String externalNetworkProviderLabel();
Line 361:
Line 362: @DefaultStringValue("If you would like this host's networks to be
provisioned by an external provider, please choose it from the list.")
Line 363: String externalProviderExplanation();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/provider/HostNetworkProviderWidget.java
Line 1: package org.ovirt.engine.ui.common.widget.uicommon.popup.provider;
Why isn't it in the webadmin package? AFAIK the user portal doesn't use it.
Line 2:
Line 3: import org.ovirt.engine.core.common.businessentities.Provider;
Line 4: import org.ovirt.engine.ui.common.CommonApplicationConstants;
Line 5: import org.ovirt.engine.ui.common.CommonApplicationTemplates;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml
Line 54: </ui:style>
Line 55:
Line 56: <d:SimpleDialogPanel width="700px" height="400px">
Line 57: <d:content>
Line 58: <t:DialogTabPanel height="100%">
TWS
Line 59: <t:tab>
Line 60: <t:DialogTab
label="{constants.hostPopupGeneralTabLabel}">
Line 61: <t:content>
Line 62: <g:VerticalPanel
width="100%" addStyleNames="{style.content}">
--
To view, visit http://gerrit.ovirt.org/17252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3748b7c8b7f7cd277bf1929a8a91168793501696
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
