Sahina Bose has posted comments on this change.
Change subject: restapi: Modified gluster volume rebalance action
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java
Line 45: @Formatted
Line 46: @Consumes({ ApiMediaType.APPLICATION_XML,
ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML })
Line 47: @Actionable
Line 48: @Path("startrebalance")
Line 49: public Response startRebalance(Action action);
You will need to change the action name in getActionSubResource and in
rsdl_metadata.yaml file as well.
How about deprecating the existing rebalance and creating a new method
startRebalance for backward compatibility?
Line 50:
Line 51: @POST
Line 52: @Formatted
Line 53: @Consumes({ ApiMediaType.APPLICATION_XML,
ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML })
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 3203: <xs:element name="stripe_count" type="xs:unsignedShort"
minOccurs="0" maxOccurs="1"/>
Line 3204: <xs:element ref="bricks" minOccurs="0" maxOccurs="1"/>
Line 3205: <xs:element ref="options" minOccurs="0" maxOccurs="1"/>
Line 3206: <xs:element ref="status" minOccurs="0" maxOccurs="1"/>
Line 3207: <xs:element name="task_id" type="xs:string" minOccurs="0"
maxOccurs="1"/>
I think you will need to change this to a glustertask type, to reflect the
gluster volume entity change
Line 3208: </xs:sequence>
Line 3209: </xs:extension>
Line 3210: </xs:complexContent>
Line 3211: </xs:complexType>
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java
Line 61:
Line 62: @Override
Line 63: public Response startRebalance(Action action) {
Line 64: boolean fixLayoutOnly = (action.isSetFixLayout() ?
action.isFixLayout() : false);
Line 65: boolean force = (action.isSetForce() ? action.isForce() :
false);
fixLayout and force are not supported for startRebalance
Line 66: return doAction(VdcActionType.StartRebalanceGlusterVolume,
Line 67: new GlusterVolumeRebalanceParameters(guid,
Line 68: fixLayoutOnly,
Line 69: force), action);
--
To view, visit http://gerrit.ovirt.org/18208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9fd560cc1b6a0db9cc28647bc311cb9f1b9e3b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
