Omer Frenkel has posted comments on this change.
Change subject: core: allow using cloud init only from 3.3
......................................................................
Patch Set 4:
(2 comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 216: ACTION_TYPE_FAILED_STORAGE_POOL_NAME_ALREADY_EXIST=Cannot ${action}
${type}. The Data Center name is already in use.
Line 217: ACTION_TYPE_FAILED_TEMPLATE_NOT_FOUND_ON_DESTINATION_DOMAIN=Cannot
${action} ${type}. The selected Storage Domain does not contain the VM Template.
Line 218: ACTION_TYPE_FAILED_NO_VDS_IN_POOL=Cannot ${action} ${type}. There is
no active Host in the Data Center.
Line 219: ACTION_TYPE_FAILED_REQUESTED_DISK_SIZE_IS_TOO_SMALL=Cannot ${action}
${type} size. New disk size must be larger than current disk size.
Line 220: ACTION_TYPE_FAILED_CLOUD_INIT_IS_NOT_SUPPORTED=Cannot ${action}
${type}. Cloud-Init is not supported in this cluster compatibility version.
will do
Line 221: VAR__TYPE__HOST=$type Host
Line 222: VAR__ENTITIES__HOSTS=$entities hosts
Line 223: VAR__TYPE__NETWORK=$type Network
Line 224: VAR__TYPE__NETWORKS=$type Networks
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 205: select fn_db_add_config_value('NetworkQosSupported','false','3.1');
Line 206: select fn_db_add_config_value('NetworkQosSupported','false','3.2');
Line 207: select fn_db_add_config_value('CloudInitSupported','false','3.0');
Line 208: select fn_db_add_config_value('CloudInitSupported','false','3.1');
Line 209: select fn_db_add_config_value('CloudInitSupported','false','3.2');
why? there was a discussion on that already on engine devel and it was decided
its ok to go this way (values that are similar to the default value doest have
to be explicitly written here) you can see it even above and in more places
already
Line 210:
Line 211: -- by default use no proxy
Line 212: select fn_db_add_config_value('SpiceProxyDefault','','general');
Line 213:
--
To view, visit http://gerrit.ovirt.org/17476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88d4ba3ca4dc24bdd3c12aeaf8168683e60096d9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches