Alon Bar-Lev has posted comments on this change.

Change subject: core: sort or randomize events
......................................................................


Patch Set 2:

(1 comment)

....................................................
File src/otopi/context.py
Line 277:         if self.environment[constants.BaseEnv.RANDOMIZE_EVENTS]:
Line 278:             random.shuffle(tmplist)
Line 279:         else:
Line 280:             # Set some stable order
Line 281:             tmplist.sort(key=lambda x: x['name'])
but we do not have name for each.

won't it better to sort by python class + method name?
Line 282: 
Line 283:         #
Line 284:         # sort based on priority
Line 285:         #


-- 
To view, visit http://gerrit.ovirt.org/18478
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a81095dc4f90e523028b3f5b30c6045829f8ca1
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to