Arik Hadas has posted comments on this change.
Change subject: core: remove MigrateVmCommand#canMigrateVm
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java
Line 29: * the internal migration command should fail
Line 30: */
Line 31: @Override
Line 32: protected boolean canDoAction() {
Line 33: if (getVm().getMigrationSupport() ==
MigrationSupport.MIGRATABLE) {
right, I fixed such bug in http://gerrit.ovirt.org/#/c/18474 but I didn't catch
this one..
maybe we'll keep this patch as a refactoring and add another patch that solves
that potential bug that was here before?
Line 34: return super.canDoAction();
Line 35: }
Line 36:
Line 37: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NON_MIGRTABLE);
--
To view, visit http://gerrit.ovirt.org/18468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If88012b8bdbc7d23ad9350acf207431727e1d51e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
