Mike Kolesnik has posted comments on this change.
Change subject: engine: Consider case-sensitivity for mac-address uniqueness
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
Line 298: if (allocatedMacs.containsKey(mac) ||
allocatedCustomMacs.containsKey(mac)) {
Line 299: return true;
Line 300: }
Line 301:
Line 302: for (String macAddress : allocatedMacs.keySet()) {
You're basically repeating the check from above but in an explicit way.
How about instead store in the maps just macs in one format (either lower or
upper case) and look just for that?
Line 303: if (StringUtils.equalsIgnoreCase(macAddress, mac)) {
Line 304: return true;
Line 305: }
Line 306: }
--
To view, visit http://gerrit.ovirt.org/18490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57516cc710648b37a9cebcdfce592c2418a7e192
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
