Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: Separate remove and add
......................................................................
Patch Set 9:
(2 comments)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 57: pass
Line 58:
Line 59: def abort(self):
Line 60: try:
Line 61: for zone in self._parent._disabled_zones_services:
what about using iteritems?
Line 62: for service in
self._parent._disabled_zones_services[zone]:
Line 63: self._parent.execute(
Line 64: (
Line 65:
self._parent.command.get('firewall-cmd'),
Line 59: def abort(self):
Line 60: try:
Line 61: for zone in self._parent._disabled_zones_services:
Line 62: for service in
self._parent._disabled_zones_services[zone]:
Line 63: self._parent.execute(
no no no....
rc, stdout, stderr = execute(
args=(
),
raiseOnError=False,
)
if rc != 0:
logger.debug('....')
Line 64: (
Line 65:
self._parent.command.get('firewall-cmd'),
Line 66: '--zone', zone,
Line 67: '--permanent',
--
To view, visit http://gerrit.ovirt.org/18476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d
Gerrit-PatchSet: 9
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
