Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding RpmVersion utils
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/RpmVersionUtils.java
Line 47: *
Line 48: * @param rpmName
Line 49: * @return
Line 50: */
Line 51: public static String[] splitRpmToParts(String rpmName) {
After reading the usage in http://gerrit.ovirt.org/#/c/17987, I wondered, maybe
you can return dict, for readability, or something similar to namedtuple in
java, to have ret['release'] ret['version'] ret['prefix'] -> easier to work
with.
Line 52: int lastDashIndex = rpmName.lastIndexOf('-');
Line 53: if (lastDashIndex == -1) {
Line 54: throw new
IllegalArgumentException(INVALID_RPM_NAME_FORMAT);
Line 55: }
--
To view, visit http://gerrit.ovirt.org/18370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia82d09e755b767f254224c84abd16516592715ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
