Mike Kolesnik has posted comments on this change.
Change subject: core: Validate vm nic name has no special characters
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
Line 64: }
Line 65:
Line 66: @NotNull(message = VmNic.VALIDATION_MESSAGE_NAME_NOT_NULL, groups
= { CreateEntity.class,
Line 67: UpdateEntity.class })
Line 68: @Pattern(regexp = ValidationUtils.NO_SPECIAL_CHARACTERS_WITH_DOT,
message = "VALIDATION_NAME_INVALID_WITH_DOT",
Since you're already adding a generic message for this case, how about adding
an annotation such as @ValidName for example @ValidNameWithDot that will be
used wherever this regular expression is needed, and have this message as
default?
Line 69: groups = { CreateEntity.class, UpdateEntity.class })
Line 70: @Override
Line 71: public String getName() {
Line 72: return super.getName();
--
To view, visit http://gerrit.ovirt.org/18487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I596f546473b1e4c8832aa56dd56320df514977ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
