Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18572
to review the following change.
Change subject: engine: AddClusterPolicyCommand canDoAction simplification
......................................................................
engine: AddClusterPolicyCommand canDoAction simplification
AddClusterPolicyCommand canDoAction simplification
Change-Id: I31d7db46e6f0c086f2a48f8217bda4d175448803
Signed-off-by: Laszlo Hornyak <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/18572/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java
index c2f9924..7680047 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java
@@ -14,10 +14,7 @@
@Override
protected boolean canDoAction() {
- if (!checkAddEditValidations()) {
- return false;
- }
- return true;
+ return checkAddEditValidations();
}
@Override
--
To view, visit http://gerrit.ovirt.org/18572
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31d7db46e6f0c086f2a48f8217bda4d175448803
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches