Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: custom properties sheet: tooltip for key ......................................................................
webadmin: custom properties sheet: tooltip for key Show tool-tip for selected key, when hovering on keys drop-down. Since keys are user defined it can overflow the widget width, therefore a tooltip is needed. Change-Id: I2118f78e340923e89e0008c2c8b8bb9c9a19466b Signed-off-by: Gilad Chaplik <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/18552/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java index 94d42ae..ee3a0f8 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java @@ -4,6 +4,9 @@ import org.ovirt.engine.ui.common.widget.editor.EntityModelTextBoxEditor; import org.ovirt.engine.ui.common.widget.editor.ListModelListBoxEditor; import org.ovirt.engine.ui.uicommonweb.models.vms.key_value.KeyValueLineModel; +import org.ovirt.engine.ui.uicompat.Event; +import org.ovirt.engine.ui.uicompat.EventArgs; +import org.ovirt.engine.ui.uicompat.IEventListener; import com.google.gwt.core.client.GWT; import com.google.gwt.editor.client.SimpleBeanEditorDriver; @@ -88,10 +91,28 @@ object.getRemoveLine().execute(); } }); - + updateKeyTitle(object); + object.getKeys().getSelectedItemChangedEvent().addListener(new IEventListener() { + @Override + public void eventRaised(Event ev, Object sender, EventArgs args) { + updateKeyTitle(object); + } + }); driver.edit(object); } + /** + * set dropdown with selected key tooltip. + */ + private void updateKeyTitle(KeyValueLineModel object) { + String selectedKey = (String) object.getKeys().getSelectedItem(); + // Setting the title to null results in the string "null" being displayed on some browsers. + if (selectedKey == null) { + selectedKey = ""; + } + keyField.getElement().setTitle(selectedKey); + } + @Override public KeyValueLineModel flush() { return driver.flush(); -- To view, visit http://gerrit.ovirt.org/18552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2118f78e340923e89e0008c2c8b8bb9c9a19466b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
