Hello Laszlo Hornyak,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/18557

to review the following change.

Change subject: engine: start discovery thread only if enabled
......................................................................

engine: start discovery thread only if enabled

Checks the external scheduler configuration before starting the external
scheduler discovery thread. Added logging for better tracing.

Change-Id: Ibac067131d3725d39afaf2f4941165eccdb60372
Signed-off-by: Laszlo Hornyak <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/18557/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
index c11aa90..87cb89d 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
@@ -82,8 +82,13 @@
         log.info("Initializing Scheduling manager");
         loadPolicyUnits();
         loadClusterPolicies();
-        ExternalSchedulerDiscoveryThread discoveryThread = new 
ExternalSchedulerDiscoveryThread();
-        discoveryThread.start();
+        if(Config.GetValue(ConfigValues.ExternalSchedulerEnabled)) {
+            log.info("Starting external scheduler dicovery thread");
+            ExternalSchedulerDiscoveryThread discoveryThread = new 
ExternalSchedulerDiscoveryThread();
+            discoveryThread.start();
+        } else {
+            log.info("External scheduler disabled, discovery skipped");
+        }
         log.info("Initialized Scheduling manager");
     }
 


-- 
To view, visit http://gerrit.ovirt.org/18557
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibac067131d3725d39afaf2f4941165eccdb60372
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to