Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Prevent cleanup without setup
......................................................................
Patch Set 1:
(3 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-remove/core/misc.py
Line 79: self.environment[osetupcons.CoreEnv.GENERATE_POSTINSTALL] =
False
Line 80: if not os.path.exists(
Line 81: osetupcons.FileLocations.OVIRT_SETUP_POST_INSTALL_CONFIG
Line 82: ):
Line 83: self.logger.error(_('Could not detect setup'))
In precise terms: Could not see that the new version of engine-setup was
successfully run and finished.
Not sure how to phrase that nicely for the user.
Line 84: self.dialog.note(
Line 85: text=_(
Line 86: 'Please use the cleanup utility only after a setup
'
Line 87: 'or after an upgrade from an older installation.\n'
Line 83: self.logger.error(_('Could not detect setup'))
Line 84: self.dialog.note(
Line 85: text=_(
Line 86: 'Please use the cleanup utility only after a setup
'
Line 87: 'or after an upgrade from an older installation.\n'
Done
Line 88: )
Line 89: )
Line 90: if os.path.exists(
Line 91:
osetupcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_CERT
Line 93: self.dialog.note(
Line 94: text=_(
Line 95: 'If you want to cleanup after setup of a
previous '
Line 96: 'version, you should use the setup package of
that '
Line 97: 'version.\n'
Done
Line 98: )
Line 99: )
Line 100: raise RuntimeError(
Line 101: _('Could not detect setup')
--
To view, visit http://gerrit.ovirt.org/18591
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1dc356976ada9029895b237bd6a0b4771dea64b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
