Hello Vojtech Szocs,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18620
to review the following change.
Change subject: build: Fix gwt-debug target in Makefile
......................................................................
build: Fix gwt-debug target in Makefile
Currently, gwt-debug target executes following command:
mvn $(DEV_BUILD_FLAGS) ...
This means DEV_BUILD_FLAGS can apply parameters that aren't
relevant and/or shouldn't even be specified when launching
GWT Developer Mode, such as:
-Pgwtdraft [via DEV_BUILD_GWT_DRAFT]
-Dgwt.userAgent [via DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS]
Since DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS defaults to using
Firefox (-Dgwt.userAgent=gecko1_8), if someone wants to
debug GWT application in Chrome (or any other browser), he
must override DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS with empty
string, for example:
make gwt-debug webadmin \
DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS=""
In other words, gwt-debug target shouldn't apply GWT-compile
time parameters, such as -Dgwt.userAgent=...
Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb
Signed-off-by: Vojtech Szocs <[email protected]>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/18620/1
diff --git a/Makefile b/Makefile
index 9103abb..05233cb 100644
--- a/Makefile
+++ b/Makefile
@@ -387,7 +387,7 @@
[ -n "$(DEBUG_MODULE)" ] || ( echo "Please specify DEBUG_MODULE" &&
false )
cd "frontend/webadmin/modules/$(DEBUG_MODULE)" && \
$(MVN) \
- $(DEV_BUILD_FLAGS) \
+ $(DEV_EXTRA_BUILD_FLAGS) \
-Dgwt.noserver=true \
-Pgwtdev,gwt-admin,gwt-user \
gwt:debug
--
To view, visit http://gerrit.ovirt.org/18620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
