Arik Hadas has posted comments on this change. Change subject: core: cleanup in MoveOrCopyDiskCommand ......................................................................
Patch Set 4: Sergey, I find it better to call fields which shouldn't be used directly with 'cached' prefix. There are places where command holds fields that are retrieved in one place and you don't want to pass them in the methods arguments along the flow so you save them as class fields so that they will be accessible from anywhere else, but in this case the developer should be aware that he should access the field only by its getter method, so I mark such field with the 'cached' prefix. I did it in other virt/network/storage places, I didn't get any negative feedback on it yet so I assume people accept it. -- To view, visit http://gerrit.ovirt.org/18007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28853bca622bf19ef66c983fa2d7ea38b943fa7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
