Allon Mureinik has posted comments on this change.
Change subject: engine : endAction run multiple times When RuntimeException
occurs
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
Line 165: finally {
Line 166: // if a RuntimeExcpetion occurs we clear the task from db
and perform no other action
Line 167: if (endActionRuntimeException) {
Line 168: handleEndActionRuntimeException(entityInfo,
dbAsyncTask);
Line 169: return;
not a big fan of the if..return idiom.
why not just use an else statement?
Line 170: }
Line 171: boolean isTaskGroupSuccess =
dbAsyncTask.getActionParameters().getTaskGroupSuccess();
Line 172: handleEndActionResult(entityInfo, vdcReturnValue,
context, isTaskGroupSuccess);
Line 173: }
--
To view, visit http://gerrit.ovirt.org/18609
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50d7688c9f06ae90bed3d80c286534311f5afb1c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
