Michal Skrivanek has posted comments on this change. Change subject: engine: VM Device Type for Display Type ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/conf/osinfo-defaults.properties Line 48: os.other.devices.audio.value = ich6 Line 49: # See VmInterfaceType.java Line 50: os.other.devices.network.value = rtl8139, e1000, pv Line 51: os.other.devices.vnc.vmDeviceType.value = cirrus Line 52: os.other.devices.qxl.vmDeviceType.value = qxl why not having it just as a single list of supported devices? e.g. "os.other.display.value=qxl, cirrus, vga" and for now it would be enough to keep an internal mapping of qxl means SPICE is supported, others mean VNC is supported. (there can be both) this way we can get rid of os.other.spiceSupport.value = true and make it way more flexible for future Line 53: Line 54: os.linux.id.value = 100 Line 55: os.linux.name.value = Linux Line 56: os.linux.derivedFrom.value = other -- To view, visit http://gerrit.ovirt.org/18677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326f8aaf0de95332436499205f90336d2f4e73d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
