Alex Lourie has uploaded a new change for review.

Change subject: packaging: setup: stop and warn if setup is not run as root 
user.
......................................................................

packaging: setup: stop and warn if setup is not run as root user.

Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41
Bug-Url: https://bugzilla.redhat.com/853957
Signed-off-by: Alex Lourie <[email protected]>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-reports refs/changes/55/18755/1

diff --git a/packaging/ovirt-engine-reports-setup.py 
b/packaging/ovirt-engine-reports-setup.py
index 22da336..651751d 100755
--- a/packaging/ovirt-engine-reports-setup.py
+++ b/packaging/ovirt-engine-reports-setup.py
@@ -20,6 +20,7 @@
 import tempfile
 import re
 import glob
+import pwd
 
 log_file = utils.initLogging("ovirt-engine-reports-setup", 
"/var/log/ovirt-engine")
 
@@ -71,6 +72,17 @@
 /usr/bin/dropdb -U %s -h %s -p %s %s"
 
 DIR_TEMP_SCHEDUALE=tempfile.mkdtemp()
+
+def _verifyUserPermissions():
+    username = pwd.getpwuid(os.getuid())[0]
+    if os.geteuid() != 0:
+        sys.exit(
+            'Error: insufficient permissions for user {user}, '
+            'you must run with user root.'.format(
+                user=username
+            )
+        )
+
 
 @transactionDisplay("Deploying Server")
 def deployJs(db_dict):
@@ -666,6 +678,9 @@
     '''
     main
     '''
+    # Check permissions first
+    _verifyUserPermissions()
+
     global db_dict
     rc = 0
     preserveReportsJobs = False


-- 
To view, visit http://gerrit.ovirt.org/18755
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to