Mike Kolesnik has posted comments on this change.
Change subject: engine: Extract vnic profile helper methods to VnicProfileHelper
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 367:
Line 368: /**
Line 369: * Functionality of this method should be implemented in
subclasses
Line 370: */
Line 371: protected AuditLogType getAuditLogTypeForInvalidInterfaces() {
I think this method can be also removed..
Line 372: return AuditLogType.UNASSIGNED;
Line 373: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java
Line 52: * @param iface
Line 53: * The vm network interface to be updated
Line 54: * @param userId
Line 55: * The id of the user which performs the action
Line 56: * @return {@code true} if the vnic profile id is updated, else
{@code false}
Don't see that the method returns anything..
Line 57: */
Line 58: public void updateNicWithVnicProfileForUser(VmNetworkInterface
vmInterface, Guid userId) {
Line 59: if (!updateNicWithVnicProfile(vmInterface, userId)) {
Line 60: markNicHasNoProfile(vmInterface);
--
To view, visit http://gerrit.ovirt.org/18797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03ae924a6fb31a948723a57b331597ec7d76977
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
