Hi,
Did you get anywhere with this? I'd be interested in helping out assembling
an Engines plugin for 2.0
On Nov 25, 2007 4:06 PM, Sven Fuchs <[EMAIL PROTECTED]> wrote:
> Hi James,
>
> I've now managed to look through the codebase.
>
> Basically I'd like to start refactoring from my patch and successively
> remove duplicate functionality.
>
> I'm not sure if it makes sense to partition this up (you asked for
> investigations as to which parts of the codebase I'd want to touch).
> As far as I can see there's:
>
> - the Engines' plugin class could probably be replaced by a module
> that would be mixed into the Rails::Plugin class
> - some of the Engine module could probably moved to
> Rails::Plugin::Loader or to a Engine::PluginLoader that extends from
> the latter
> - a dedicated Engine::PluginLocator might be superflous then because
> the Rails::Plugin class would be used and Rails::Plugin::Loader seems
> to keep track of the plugin instances (is it accessible though?)
> - Engines::RailsExtensions::RailsInitializer could be removed (it
> already is in my patch)
>
> These might be fine as they are:
>
> Engines::PluginMigrator
> Engines::RailsExtensions::ActiveRecord
> Engines::RailsExtensions::Dependencies
> Engines::RailsExtensions::Migrations
> Engines::RailsExtensions::PublicAssetHelpers
> Engines::RailsExtensions::Templates
>
> I've also looked for test suites in the repository. There seem to be
> several applications for testing different Rails versions. The "rails
> edge" application doesn't seem to have any engines installed, the
> tests seem to rely on them though ("alpha_engine" etc.). Am I missing
> something obvious?
>
--
Tony Arcieri
ClickCaster, Inc.
[EMAIL PROTECTED]
_______________________________________________
Engine-Users mailing list
[email protected]
http://lists.rails-engines.org/listinfo.cgi/engine-users-rails-engines.org
