Hi,

Tacvek wrote:
Ok. I just got an Enigma version to work correctly with a C++ lua build. :D
Works correctly as in does not crash on any of those tests.

Great!

Either of the patches can be used to stop the crashing on Windows.

The patch called simple compiles liblua as C++ and disables building the tolua++ tool
for all MingW32 compiles.

The patch named complex is my preffered patch. It adds a new configure option: --enable-cxxlua/--disable--cxxlua. This option causes liblua to be compiled as C++ and disbales building the tolua++ tool. It defaults to disabled, except on MingW32,
where it defaults to enabled.


The second patch would be the preferable patch.

I compile on Windows, too. But it is not essential to build a Windows
tolua++ within Enigma. Is a tolua++ build possible with your "--disable-cxxlua"


There should be absolutely no changes versus the current situation if you are using
--disable-cxxlua.
Every single change (except those to configure) should be properly set off by preprocessor
directives, or the equivlent for the automake changes.

Well I had to make a minor change to your configure.ac patch that did
not accept --disable-cxxlua if MINGW32 was set.

I added the commands to build tolua++ to the README.mingw32 and will
immediatly commit all these changes.

Both patches require editing two files that enigma does not own, namely luaconf.h
and tolua++.h.

You may want to propagate the luaconf.h patch - the change from
"catch(...)" to "catch(lua_longjmp*)" - to the Lua developers as the first version is definitly broken.

- Ronald



_______________________________________________
Enigma-devel mailing list
Enigma-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/enigma-devel

Reply via email to