On 15.02.18 06:49, Daniel Kahn Gillmor wrote:
> On Thu 2018-02-15 00:44:28 -0500, Daniel Kahn Gillmor wrote:
>> By expressing the rule to create package/buildDate.jsm as a way to
>> target buildDate.jsm, make will force it to happen in order.
>> otherwise, parallel build processes might try to invoke the deploy
>> rule first.
>> Note that if your goal is to rebuild buildDate.jsm each time you
>> build, this changeset not work, because once created, buildDate.jsm
>> will not be updated.
>> However, in that same case, a parallel build offers no guarantees that
>> buildDate.jsm will actually be updated before the deploy rules fires,
>> so a parallel build could also include the older (unupdated) version
>> of package/buildDate.jsm, non-deterministically.
> btw, if the goal is really to always recreate buildDate.jsm, then it
> should be removed from MODFILES and the three-step file generation can
> be added directly to rule under the "deploy" target.

That's the goal indeed. The idea is that buildDate.jsm is updated
_every_ time you create a build.

> Either this approach or the proposed patch is the right thing to do;
> both are better than the current state, which behaves poorly with
> parallel builds.

You're right. I'll look into it.


Attachment: signature.asc
Description: OpenPGP digital signature

enigmail-users mailing list
To unsubscribe or make changes to your subscription click here:

Reply via email to