Hi Patrick! On Sat 2018-05-26 18:31:46 +0200, Patrick Brunschwig wrote: >> It'd be really great if there was a test suite that could exercise all >> the expected functionality, so i could be sure my changes don't breaking >> them. do you have anything like such a suite that i could piggyback on? > > Run the unit tests in package. I think that almost everything covered by > tests, except for the ASM.
OK, I've removed OpenPGP.js from enigmail for testing in the most simple possible way -- just ripping out the files to see what breaks. And i've got a dedicated virtual machine that is running eslint directly from npm so i can run all the tests. You can find my edits to the enigmail source on the "enigmail-2.0-no-openpgp.js" branch at https://gitlab.com/dkg/enigmail.git below are the results from running "make test" against this branch. I don't see any errors in them except for a few warnings about unused labels, and some eslint complaints about excessive escaping in some regular expressions. fwiw, i see the exact same output when i run "make test" against the branch "enigmail-2.0-branch", without my changes. Are there other test suites i can run to actually exercise the parts where OpenPGP.js is used? I was hoping that this approach would highight all the breakage that i need to fix, but i'm not seeing it. Regards, --dkg 0 $ make test static_analysis/eslint ipc static_analysis/eslint package /home/npmuser/src/enigmail/enigmail/package/decryption.jsm 101:34 warning Unnecessary escape character: \( no-useless-escape 101:36 warning Unnecessary escape character: \) no-useless-escape /home/npmuser/src/enigmail/enigmail/package/files.jsm 523:47 warning Unnecessary escape character: \/ no-useless-escape /home/npmuser/src/enigmail/enigmail/package/keyRing.jsm 308:38 warning Unnecessary escape character: \. no-useless-escape 308:40 warning Unnecessary escape character: \[ no-useless-escape /home/npmuser/src/enigmail/enigmail/package/mime.jsm 353:27 warning Unnecessary escape character: \? no-useless-escape 387:26 warning Unnecessary escape character: \? no-useless-escape ✖ 7 problems (0 errors, 7 warnings) static_analysis/eslint ui util/checkFiles.py checkXUL() ./ui/content/enigmailImportPhoto.xul checkXUL() ./ui/content/enigmailKeySelection.xul checkXUL() ./ui/content/exportSettingsWizard.xul checkXUL() ./ui/content/pepTrustWords.xul checkXUL() ./ui/content/keyDetailsDlg.xul checkXUL() ./ui/content/enigmailFilterEditorOverlay.xul checkXUL() ./ui/content/enigmailMessengerOverlay.xul checkXUL() ./ui/content/enigmailGenericDisplay.xul checkXUL() ./ui/content/enigmailRulesEditor.xul checkXUL() ./ui/content/pref-pep.xul checkXUL() ./ui/content/enigmailAbCardViewOverlay.xul checkXUL() ./ui/content/enigmailEditKeyTrustDlg.xul checkXUL() ./ui/content/autocryptSetupPasswd.xul checkXUL() ./ui/content/enigmailCustToolOverlay.xul checkXUL() ./ui/content/enigmailEncryptionDlg.xul checkXUL() ./ui/content/enigmailAbContactsPanel.xul checkXUL() ./ui/content/enigmailConsole.xul checkXUL() ./ui/content/enigmailWrapSelection.xul checkXUL() ./ui/content/enigmailMsgComposeOverlay.xul checkXUL() ./ui/content/pref-enigmail.xul checkXUL() ./ui/content/enigmailMsgPrintOverlay.xul checkXUL() ./ui/content/enigmailDispPhoto.xul checkXUL() ./ui/content/enigmailKeygen.xul checkXUL() ./ui/content/pepHandshake.xul checkXUL() ./ui/content/enigmailCardDetails.xul checkXUL() ./ui/content/enigmailKeyserverDlg.xul checkXUL() ./ui/content/enigmailManageUidDlg.xul checkXUL() ./ui/content/enigmailMsgComposeOverlay-sm.xul checkXUL() ./ui/content/enigmailCheckLanguage.xul checkXUL() ./ui/content/enigmailSetCardPin.xul checkXUL() ./ui/content/enigmailSelectRule.xul checkXUL() ./ui/content/enigmailSingleRcptSettings.xul checkXUL() ./ui/content/enigmailPrivacyOverlay.xul checkXUL() ./ui/content/columnOverlay.xul checkXUL() ./ui/content/enigmailFilterListOverlay.xul checkXUL() ./ui/content/enigmailAddUidDlg.xul checkXUL() ./ui/content/enigmailMsgBox.xul checkXUL() ./ui/content/editSingleAccount.xul checkXUL() ./ui/content/pepPrepHandshake.xul checkXUL() ./ui/content/enigmailHelp.xul checkXUL() ./ui/content/messengerOverlay-sm.xul checkXUL() ./ui/content/enigmailPrefsOverlay.xul checkXUL() ./ui/content/enigmailEditKeyExpiryDlg.xul checkXUL() ./ui/content/autocryptInitiateBackup.xul checkXUL() ./ui/content/accountManagerOverlay.xul checkXUL() ./ui/content/messengerOverlay-tbird.xul checkXUL() ./ui/content/enigmailSignKeyDlg.xul checkXUL() ./ui/content/enigmailKeyManager.xul checkXUL() ./ui/content/enigmailKeyImportInfo.xul checkXUL() ./ui/content/enigmailAmIdEditOverlay.xul checkXUL() ./ui/content/enigmailMsgHdrViewOverlay.xul checkXUL() ./ui/content/enigmailSearchKey.xul checkXUL() ./ui/content/enigmailEditIdentity.xul checkXUL() ./ui/content/am-enigprefs.xul checkXUL() ./ui/content/enigmailAdvancedIdentityDlg.xul checkXUL() ./ui/content/enigmailViewFile.xul checkXUL() ./ui/content/enigRetrieveProgress.xul checkXUL() ./ui/content/enigmailAttachmentsDialog.xul checkXUL() ./ui/content/enigmailSetupWizard.xul checkXUL() ./ui/content/enigmailGenCardKey.xul checkXUL() ./build/dist/chrome/content/enigmailImportPhoto.xul checkXUL() ./build/dist/chrome/content/enigmailKeySelection.xul checkXUL() ./build/dist/chrome/content/exportSettingsWizard.xul checkXUL() ./build/dist/chrome/content/pepTrustWords.xul checkXUL() ./build/dist/chrome/content/keyDetailsDlg.xul checkXUL() ./build/dist/chrome/content/enigmailFilterEditorOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailMessengerOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailGenericDisplay.xul checkXUL() ./build/dist/chrome/content/enigmailRulesEditor.xul checkXUL() ./build/dist/chrome/content/pref-pep.xul checkXUL() ./build/dist/chrome/content/enigmailAbCardViewOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailEditKeyTrustDlg.xul checkXUL() ./build/dist/chrome/content/autocryptSetupPasswd.xul checkXUL() ./build/dist/chrome/content/enigmailCustToolOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailEncryptionDlg.xul checkXUL() ./build/dist/chrome/content/enigmailAbContactsPanel.xul checkXUL() ./build/dist/chrome/content/enigmailConsole.xul checkXUL() ./build/dist/chrome/content/enigmailWrapSelection.xul checkXUL() ./build/dist/chrome/content/enigmailMsgComposeOverlay.xul checkXUL() ./build/dist/chrome/content/pref-enigmail.xul checkXUL() ./build/dist/chrome/content/enigmailMsgPrintOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailDispPhoto.xul checkXUL() ./build/dist/chrome/content/enigmailKeygen.xul checkXUL() ./build/dist/chrome/content/pepHandshake.xul checkXUL() ./build/dist/chrome/content/enigmailCardDetails.xul checkXUL() ./build/dist/chrome/content/enigmailKeyserverDlg.xul checkXUL() ./build/dist/chrome/content/enigmailManageUidDlg.xul checkXUL() ./build/dist/chrome/content/enigmailMsgComposeOverlay-sm.xul checkXUL() ./build/dist/chrome/content/enigmailCheckLanguage.xul checkXUL() ./build/dist/chrome/content/enigmailSetCardPin.xul checkXUL() ./build/dist/chrome/content/enigmailSelectRule.xul checkXUL() ./build/dist/chrome/content/enigmailSingleRcptSettings.xul checkXUL() ./build/dist/chrome/content/enigmailPrivacyOverlay.xul checkXUL() ./build/dist/chrome/content/columnOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailFilterListOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailAddUidDlg.xul checkXUL() ./build/dist/chrome/content/enigmailMsgBox.xul checkXUL() ./build/dist/chrome/content/editSingleAccount.xul checkXUL() ./build/dist/chrome/content/pepPrepHandshake.xul checkXUL() ./build/dist/chrome/content/enigmailHelp.xul checkXUL() ./build/dist/chrome/content/messengerOverlay-sm.xul checkXUL() ./build/dist/chrome/content/enigmailEditKeyExpiryDlg.xul checkXUL() ./build/dist/chrome/content/autocryptInitiateBackup.xul checkXUL() ./build/dist/chrome/content/accountManagerOverlay.xul checkXUL() ./build/dist/chrome/content/messengerOverlay-tbird.xul checkXUL() ./build/dist/chrome/content/enigmailSignKeyDlg.xul checkXUL() ./build/dist/chrome/content/enigmailKeyManager.xul checkXUL() ./build/dist/chrome/content/enigmailKeyImportInfo.xul checkXUL() ./build/dist/chrome/content/enigmailAmIdEditOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailMsgHdrViewOverlay.xul checkXUL() ./build/dist/chrome/content/enigmailSearchKey.xul checkXUL() ./build/dist/chrome/content/enigmailEditIdentity.xul checkXUL() ./build/dist/chrome/content/am-enigprefs.xul checkXUL() ./build/dist/chrome/content/enigmailAdvancedIdentityDlg.xul checkXUL() ./build/dist/chrome/content/enigmailViewFile.xul checkXUL() ./build/dist/chrome/content/enigRetrieveProgress.xul checkXUL() ./build/dist/chrome/content/enigmailAttachmentsDialog.xul checkXUL() ./build/dist/chrome/content/enigmailSetupWizard.xul checkXUL() ./build/dist/chrome/content/enigmailGenCardKey.xul checkJS() ./.eslintrc.js checkJS() ./ipc/tests/subprocess-test.js checkJS() ./ipc/tests/main.js checkJS() ./ipc/tests/.eslintrc.js checkJS() ./ipc/modules/enigmailprocess_shared.js checkJS() ./ipc/modules/enigmailprocess_common.jsm checkJS() ./ipc/modules/enigmailprocess_worker_common.js checkJS() ./ipc/modules/enigmailprocess_main.jsm checkJS() ./ipc/modules/enigmailprocess_unix.jsm checkJS() ./ipc/modules/subprocess.jsm checkJS() ./ipc/modules/enigmailprocess_worker_win.js checkJS() ./ipc/modules/enigmailprocess_worker_unix.js checkJS() ./ipc/modules/enigmailprocess_shared_win.js checkJS() ./ipc/modules/enigmailprocess_win.jsm checkJS() ./ipc/modules/enigmailprocess_shared_unix.js checkJS() ./ipc/modules/.eslintrc.js checkJS() ./.git/logs/refs/remotes/origin/enigmail-2.0-no-openpgp.js checkJS() ./.git/logs/refs/heads/enigmail-2.0-no-openpgp.js checkJS() ./.git/refs/remotes/origin/enigmail-2.0-no-openpgp.js checkJS() ./.git/refs/heads/enigmail-2.0-no-openpgp.js checkJS() ./package/mimeVerify.jsm checkJS() ./package/fixExchangeMsg.jsm checkJS() ./package/prefs.jsm checkJS() ./package/msgRead.jsm checkJS() ./package/streams.jsm checkJS() ./package/windows.jsm checkJS() ./package/locale.jsm checkJS() ./package/httpProxy.jsm checkJS() ./package/bootstrap.js checkJS() ./package/events.jsm checkJS() ./package/os.jsm checkJS() ./package/mimeEncrypt.jsm checkJS() ./package/system.jsm checkJS() ./package/decryption.jsm checkJS() ./package/app.jsm checkJS() ./package/rng.jsm checkJS() ./package/persistentCrypto.jsm checkJS() ./package/installGnuPG.jsm checkJS() ./package/rules.jsm checkJS() ./package/keyUsability.jsm checkJS() ./package/log.jsm checkJS() ./package/autocrypt.jsm checkJS() ./package/filtersWrapper.jsm checkJS() ./package/encryption.jsm checkJS() ./package/glodaUtils.jsm checkJS() ./package/funcs.jsm checkJS() ./package/constants.jsm checkJS() ./package/keyRefreshService.jsm checkJS() ./package/clipboard.jsm checkJS() ./package/send.jsm checkJS() ./package/time.jsm checkJS() ./package/files.jsm checkJS() ./package/keyserver.jsm checkJS() ./package/pEpAdapter.jsm checkJS() ./package/passwords.jsm checkJS() ./package/execution.jsm checkJS() ./package/webKey.jsm checkJS() ./package/key.jsm checkJS() ./package/installPep.jsm checkJS() ./package/timer.jsm checkJS() ./package/pgpmimeHandler.jsm checkJS() ./package/protocolHandler.jsm checkJS() ./package/wkdLookup.jsm checkJS() ./package/core.jsm checkJS() ./package/versioning.jsm checkJS() ./package/dialog.jsm checkJS() ./package/errorHandling.jsm checkJS() ./package/configure.jsm checkJS() ./package/pEpDecrypt.jsm checkJS() ./package/wksMimeHandler.jsm checkJS() ./package/armor.jsm checkJS() ./package/stdlib.jsm checkJS() ./package/pEpKeySync.jsm checkJS() ./package/passwordCheck.jsm checkJS() ./package/configBackup.jsm checkJS() ./package/socks5Proxy.jsm checkJS() ./package/zbase32.jsm checkJS() ./package/attachment.jsm checkJS() ./package/mimeDecrypt.jsm checkJS() ./package/lazy.jsm checkJS() ./package/mime.jsm checkJS() ./package/singletons.jsm checkJS() ./package/gpgAgent.jsm checkJS() ./package/pipeConsole.jsm checkJS() ./package/tor.jsm checkJS() ./package/msgCompFields.jsm checkJS() ./package/data.jsm checkJS() ./package/overlays.jsm checkJS() ./package/pEp.jsm checkJS() ./package/glodaMime.jsm checkJS() ./package/verify.jsm checkJS() ./package/uris.jsm checkJS() ./package/localizeHtml.jsm checkJS() ./package/pEpListener.jsm checkJS() ./package/openpgp.jsm checkJS() ./package/pEpFilter.jsm checkJS() ./package/gpg.jsm checkJS() ./package/filters.jsm checkJS() ./package/amPrefsService.jsm checkJS() ./package/hash.jsm checkJS() ./package/trust.jsm checkJS() ./package/card.jsm checkJS() ./package/commandLine.jsm checkJS() ./package/keyRing.jsm checkJS() ./package/addrbook.jsm checkJS() ./package/keyEditor.jsm checkJS() ./package/keyserverUris.jsm checkJS() ./package/tests/autocrypt-test.js checkJS() ./package/tests/funcs-test.js checkJS() ./package/tests/webKey-test.js checkJS() ./package/tests/installGnuPG-test.js checkJS() ./package/tests/mime-test.js checkJS() ./package/tests/keyserverUris-test.js checkJS() ./package/tests/keyRefreshService-test.js checkJS() ./package/tests/keyEditor-test.js checkJS() ./package/tests/customAssert.jsm checkJS() ./package/tests/expiry-test.js checkJS() ./package/tests/core-test.js checkJS() ./package/tests/persistentCrypto-test.js checkJS() ./package/tests/data-test.js checkJS() ./package/tests/log-test.js checkJS() ./package/tests/os-test.js checkJS() ./package/tests/errorHandling-test.js checkJS() ./package/tests/gpg-test.js checkJS() ./package/tests/main.js checkJS() ./package/tests/encryption-test.js checkJS() ./package/tests/prefs-test.js checkJS() ./package/tests/mimeDecrypt-test.js checkJS() ./package/tests/locale-test.js checkJS() ./package/tests/keyserver-test.js checkJS() ./package/tests/files-test.js checkJS() ./package/tests/execution-test.js checkJS() ./package/tests/armor-test.js checkJS() ./package/tests/keyRing-test.js checkJS() ./package/tests/pEp-test.js checkJS() ./package/tests/streams-test.js checkJS() ./package/tests/mailHelper.js checkJS() ./package/tests/gpgAgent-test.js checkJS() ./package/tests/key-test.js checkJS() ./package/tests/filters-test.js checkJS() ./package/tests/versioning-test.js checkJS() ./package/tests/system-test.js checkJS() ./package/tests/testHelper.js checkJS() ./package/tests/tor-test.js checkJS() ./package/tests/rules-test.js checkJS() ./package/tests/rng-test.js checkJS() ./package/tests/decryption-test.js checkJS() ./package/tests/.eslintrc.js checkJS() ./package/prefs/defaultPrefs.js checkJS() ./package/prefs/.eslintrc.js checkJS() ./ui/content/enigmailGenericDisplay.js checkJS() ./ui/content/enigmailSignKeyDlg.js checkJS() ./ui/content/enigmailEncryptionDlg.js checkJS() ./ui/content/pref-pep.js checkJS() ./ui/content/pepHandshake.js checkJS() ./ui/content/enigmailSetCardPin.js checkJS() ./ui/content/enigmailSearchKey.js checkJS() ./ui/content/columnOverlay.js checkJS() ./ui/content/enigmailEditIdentity.js checkJS() ./ui/content/enigmailKeySelection.js checkJS() ./ui/content/autocryptInitiateBackup.js checkJS() ./ui/content/enigmailMsgPrintOverlay.js checkJS() ./ui/content/enigmailViewFile.js checkJS() ./ui/content/enigmailAbOverlay.js checkJS() ./ui/content/enigmailDispPhoto.js checkJS() ./ui/content/enigmailGenCardKey.js checkJS() ./ui/content/enigmailMsgComposeOverlay.js checkJS() ./ui/content/enigmailEditKeyTrustDlg.js checkJS() ./ui/content/autocryptSetupPasswd.js checkJS() ./ui/content/enigmailCommon.js checkJS() ./ui/content/enigmailCardDetails.js checkJS() ./ui/content/enigmailHelp.js checkJS() ./ui/content/enigmailPrivacyOverlay.js checkJS() ./ui/content/enigmailAdvancedIdentityDlg.js checkJS() ./ui/content/exportSettingsWizard.js checkJS() ./ui/content/enigmailMessengerOverlay.js checkJS() ./ui/content/enigmailImportPhoto.js checkJS() ./ui/content/enigmailKeyImportInfo.js checkJS() ./ui/content/enigmailSingleRcptSettings.js checkJS() ./ui/content/enigmailFilterListOverlay.js checkJS() ./ui/content/enigmailMsgHdrViewOverlay.js checkJS() ./ui/content/pref-enigmail.js checkJS() ./ui/content/am-enigprefs.js checkJS() ./ui/content/accountManagerOverlay.js checkJS() ./ui/content/enigmailMsgComposeHelper.js checkJS() ./ui/content/enigRetrieveProgress.js checkJS() ./ui/content/enigmailManageUidDlg.js checkJS() ./ui/content/enigmailWrapSelection.js checkJS() ./ui/content/enigmailEditKeyExpiryDlg.js checkJS() ./ui/content/enigmailSelectRule.js checkJS() ./ui/content/enigmailKeyManager.js checkJS() ./ui/content/enigmailRulesEditor.js checkJS() ./ui/content/enigmailMsgBox.js checkJS() ./ui/content/keyDetailsDlg.js checkJS() ./ui/content/enigmailFilterEditorOverlay.js checkJS() ./ui/content/enigmailSetupWizard.js checkJS() ./ui/content/enigmailAddUidDlg.js checkJS() ./ui/content/pepTrustWords.js checkJS() ./ui/content/enigmailKeygen.js checkJS() ./ui/content/pepPrepHandshake.js checkJS() ./ui/content/enigmailConsole.js checkJS() ./ui/content/enigmailKeyserverDlg.js checkJS() ./ui/content/enigmailAttachmentsDialog.js checkJS() ./ui/tests/enigmailMsgComposeOverlay-test.js checkJS() ./ui/tests/main.js checkJS() ./ui/tests/.eslintrc.js checkJS() ./stdlib/misc.jsm checkJS() ./stdlib/compose.jsm checkJS() ./stdlib/msgHdrUtils.jsm checkHTML() ./ui/content/aboutEnigmail.html checkHTML() ./ui/content/upgradeInfo.html all 1867 labels usages are defined all 838 property usages are defined ============================================= dtdLabels: 699 found Labels: 698 false positive (or correct because in comment)?: enigmail.keyTrust.trustLevel.tooltip unused labels in 'unused.txt' ============================================= propLabels: 630 found Props: 540 false positive (or correct because in comment)?: clickDecrypt false positive (or correct because in comment)?: cmdLine false positive (or correct because in comment)?: debugLog.title false positive (or correct because in comment)?: encryptYes false positive (or correct because in comment)?: gpghomedir.notdirectory false positive (or correct because in comment)?: gpghomedir.notexists false positive (or correct because in comment)?: gpghomedir.notwritable false positive (or correct because in comment)?: handshakeDlg.label.incomingMessage false positive (or correct because in comment)?: handshakeDlg.label.outgoingMessage false positive (or correct because in comment)?: msgCompose.button.save false positive (or correct because in comment)?: pepRevokeMistrust.question false positive (or correct because in comment)?: pgpmimeNo false positive (or correct because in comment)?: pgpmimeYes false positive (or correct because in comment)?: pubKey false positive (or correct because in comment)?: sendKeysOk false positive (or correct because in comment)?: signOff false positive (or correct because in comment)?: signOn false positive (or correct because in comment)?: signYes unused props in 'unused.txt' ============================================= dtdLabels: 699 found Labels: 698 UNUSED Labels: 0 (after double check) ============================================= propLabels: 630 found Props: 540 UNUSED Props: 60 (after double check) make -C ipc/tests make[1]: Entering directory '/home/npmuser/src/enigmail/enigmail/ipc/tests' make[1]: 'all' is up to date. make[1]: Leaving directory '/home/npmuser/src/enigmail/enigmail/ipc/tests' make -C package/tests make[1]: Entering directory '/home/npmuser/src/enigmail/enigmail/package/tests' make[1]: 'all' is up to date. make[1]: Leaving directory '/home/npmuser/src/enigmail/enigmail/package/tests' make -C ui/tests make[1]: Entering directory '/home/npmuser/src/enigmail/enigmail/ui/tests' make[1]: 'all' is up to date. make[1]: Leaving directory '/home/npmuser/src/enigmail/enigmail/ui/tests' 0 $
signature.asc
Description: PGP signature
_______________________________________________ enigmail-users mailing list [email protected] To unsubscribe or make changes to your subscription click here: https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
