Enlightenment CVS committal
Author : kwo
Project : e17
Module : libs/ecore
Dir : e17/libs/ecore/src/lib/ecore_x
Modified Files:
ecore_x_window_prop.c
Log Message:
Fix client iconify.
ecore_x_window_prop_desktop_request() was probably broken too.
Suggest to remove ecore_x_window_prop_property_notify().
===================================================================
RCS file: /cvsroot/enlightenment/e17/libs/ecore/src/lib/ecore_x/ecore_x_window_prop.c,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -3 -r1.40 -r1.41
--- ecore_x_window_prop.c 7 Apr 2004 13:16:04 -0000 1.40
+++ ecore_x_window_prop.c 11 Apr 2004 21:20:47 -0000 1.41
@@ -101,6 +101,12 @@
XDeleteProperty(_ecore_x_disp, win, property);
}
+#if 0
+/*
+ * I see no purpose for a ecore_x_window_prop_property_notify().
+ * Commenting out for now, suggest to remove it entirely.
+ * /Kim
+ */
/**
* Send a property notify to a window.
* @param win The window
@@ -132,6 +138,7 @@
(SubstructureNotifyMask | SubstructureRedirectMask),
(XEvent *)&xev);
}
+#endif
/**
* Set a window string property.
@@ -827,7 +834,8 @@
xev.xclient.format = 32;
xev.xclient.data.l[0] = desktop;
- XSendEvent(_ecore_x_disp, DefaultRootWindow(_ecore_x_disp), False, 0, &xev);
+ XSendEvent(_ecore_x_disp, DefaultRootWindow(_ecore_x_disp), False,
+ SubstructureNotifyMask | SubstructureRedirectMask, &xev);
}
/**
@@ -848,8 +856,11 @@
return;
xev.xclient.type = ClientMessage;
+ xev.xclient.serial = 0;
+ xev.xclient.send_event = True;
xev.xclient.display = _ecore_x_disp;
xev.xclient.window = win;
+ xev.xclient.format = 32;
switch (state) {
case ECORE_X_WINDOW_STATE_ICONIFIED:
@@ -861,18 +872,17 @@
if (action != 1)
return;
xev.xclient.message_type = _ecore_x_atom_wm_change_state;
- xev.xclient.format = 32;
xev.xclient.data.l[0] = IconicState;
break;
default: /* The _NET_WM_STATE_... hints */
xev.xclient.message_type = _ecore_x_atom_net_wm_state;
- xev.xclient.format = 32;
xev.xclient.data.l[0] = action;
xev.xclient.data.l[1] = _ecore_x_window_prop_state_atom_get(state);
break;
}
- XSendEvent(_ecore_x_disp, DefaultRootWindow(_ecore_x_disp), False, 0, &xev);
+ XSendEvent(_ecore_x_disp, DefaultRootWindow(_ecore_x_disp), False,
+ SubstructureNotifyMask | SubstructureRedirectMask, &xev);
}
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
enlightenment-cvs mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
