Enlightenment CVS committal Author : lordchaos Project : e17 Module : libs/ewl
Dir : e17/libs/ewl/src/lib Modified Files: ewl_iconbox.c ewl_text.c Log Message: * Fix an ewl_print_warning on ewl_iconbox * Further tracking on the ewl_text/configure/random evas bug. It looks like offscreen/obscured text widgets are somehow getting added to the configure (and realize) queues. Until such time as we figure out why this is happening, add an additional OBSCURED() check to ewl_widget_configure calls on ewl_text. This shouldn't hurt anything (i hope .. dj2?), as if the widget is obscured, configure will be called on it when it is next revealed. We shouldn't have to do this, but it's ok for now. =================================================================== RCS file: /cvsroot/enlightenment/e17/libs/ewl/src/lib/ewl_iconbox.c,v retrieving revision 1.80 retrieving revision 1.81 diff -u -3 -r1.80 -r1.81 --- ewl_iconbox.c 22 Nov 2005 05:14:57 -0000 1.80 +++ ewl_iconbox.c 24 Nov 2005 11:40:36 -0000 1.81 @@ -21,7 +21,7 @@ Ewl_IconBox_Icon* icon = EWL_ICONBOX_ICON(user_data); int height = ewl_iconbox_icon_label_height_calculate(EWL_ICONBOX_ICON(icon)); - if (height >0) ewl_object_custom_h_set(EWL_OBJECT(icon->floater), height); + if (height >0) { ewl_object_custom_h_set(EWL_OBJECT(icon->floater), height); } //printf("Resized floater to EWL_TEXT(%d)-TEXTBLOCK(%d) %d\n", CURRENT_H(icon->w_label), hh, height); } =================================================================== RCS file: /cvsroot/enlightenment/e17/libs/ewl/src/lib/ewl_text.c,v retrieving revision 1.61 retrieving revision 1.62 diff -u -3 -r1.61 -r1.62 --- ewl_text.c 22 Nov 2005 16:09:59 -0000 1.61 +++ ewl_text.c 24 Nov 2005 11:40:36 -0000 1.62 @@ -451,7 +451,7 @@ if (text) ewl_text_triggers_shift(t, idx, strlen(text)); else ewl_text_triggers_remove(t); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); ewl_callback_call(EWL_WIDGET(t), EWL_CALLBACK_VALUE_CHANGED); DLEAVE_FUNCTION(DLEVEL_STABLE); @@ -512,7 +512,7 @@ if (t->cursor_position > t->length) t->cursor_position = t->length; - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); ewl_callback_call(EWL_WIDGET(t), EWL_CALLBACK_VALUE_CHANGED); @@ -857,7 +857,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -935,7 +935,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1025,7 +1025,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1111,7 +1111,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1184,7 +1184,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1257,7 +1257,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1347,7 +1347,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1450,7 +1450,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1553,7 +1553,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1656,7 +1656,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1759,7 +1759,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1862,7 +1862,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } @@ -1965,7 +1965,7 @@ t->cursor_position, length); ewl_text_context_release(tx); - ewl_widget_configure(EWL_WIDGET(t)); + if (!OBSCURED(EWL_WIDGET(t))) ewl_widget_configure(EWL_WIDGET(t)); DLEAVE_FUNCTION(DLEVEL_STABLE); } ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs