Enlightenment CVS committal
Author : onefang
Project : e17
Module : apps/e_utils
Dir : e17/apps/e_utils/src/bin/e17genmenu/src/bin
Modified Files:
icons.c
Log Message:
docs++
===================================================================
RCS file:
/cvsroot/enlightenment/e17/apps/e_utils/src/bin/e17genmenu/src/bin/icons.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -3 -r1.12 -r1.13
--- icons.c 3 Feb 2006 19:21:39 -0000 1.12
+++ icons.c 3 Feb 2006 19:59:21 -0000 1.13
@@ -150,6 +150,31 @@
char *
find_fdo_icon(char *icon, char *icon_size, char *icon_theme)
{
+ /* NOTES ON OPTIMIZATIONS
+ *
+ * The spec has this to say -
+ *
+ * "The algorithm as described in this document works by always looking up
+ * filenames in directories (a stat in unix terminology). A good
+ * implementation is expected to read the directories once, and do all
+ * lookups in memory using that information.
+ *
+ * "This caching can make it impossible for users to add icons without
having
+ * to restart applications. In order to handle this, any implementation
that
+ * does caching is required to look at the mtime of the toplevel icon
+ * directories when doing a cache lookup, unless it already did so less
than
+ * 5 seconds ago. This means that any icon editor or theme installation
+ * program need only to change the mtime of the the toplevel directory
where
+ * it changed the theme to make sure that the new icons will eventually get
+ * used."
+ *
+ * On the other hand, OS caching (at least in linux) seems to do a
reasonable
+ * job here.
+ *
+ * We could also precalculate and cache all the information extracted from
+ * the .theme files.
+ */
+
char icn[MAX_PATH], path[MAX_PATH];
char *dir, *theme_path;
char *found;
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
