Enlightenment CVS committal Author : essiene Project : e17 Module : proto
Dir : e17/proto/entrance_edit_gui/src/gui Modified Files: egui_graphics_selector.c layout.c main.c Log Message: - Modified patch sent in from Rhapsodhy for review. This patch does: - Provides ew_notice (did this by adding to ew_dialog) - due to changes, afftected how ew_dialog worked. _ used ew_notice to build ew_notice_ok() dialog. - Added an ew_box subsystem with ew_hbox_new and ew_vbox_new. _ Modified the part names of the edjes in the icons.edj - My modifications to his patch are as follows: - Revert ew_dialog back to being as simple as it was. - rather than add to ew_dialog, make ew_notice inherit from ew_dialog and add the new requirements in ew_notice. - Based on ew_notice, build an ew_messagebox dialog, currently has ew_messagebox_ok() alone. - Modified ew_group to support vertical and horizontal directions. - Modified ew_group to support being named and unamed (which will add or remove the frame borders respectively) - due to above, remove ew_box. - Added new widget ew_label. Now we have a complete ew_messagebox framework, we just need more messageboxes - Use the new ew_messagebox_ok() in gui/layout.c to show what it looks like. - Rename all the ENTRANCE_* constants to EW_* - Update TODO file With these, out api is closer to complete. We can do some more complex layouts, etc. Next, we need just a few more key widgets to be abstracted... entry, radio-button and check-box then we'll have to fix that crappy preview window to load entrance itself instead of images/edje parts. Again the rationale is, this thin api shouldn't expose too much of etk, or we'll have a hard time getting it to ewl. Also, if we begin to get really complex, what's the point? :) =================================================================== RCS file: /cvs/e/e17/proto/entrance_edit_gui/src/gui/egui_graphics_selector.c,v retrieving revision 1.2 retrieving revision 1.3 diff -u -3 -r1.2 -r1.3 --- egui_graphics_selector.c 13 Aug 2006 23:11:47 -0000 1.2 +++ egui_graphics_selector.c 14 Aug 2006 17:08:55 -0000 1.3 @@ -32,12 +32,13 @@ win = ew_dialog_new(egs.dialog_title, EW_FALSE); - group_preview = ew_dialog_group_add(win, _("Preview")); + + group_preview = ew_dialog_group_add(win, _("Preview"), EW_GROUP_VERTICAL); img_preview = ew_image_new(320, 240); ew_group_add(group_preview, img_preview); - group_graphics = ew_dialog_group_add(win, egs.list_title); + group_graphics = ew_dialog_group_add(win, egs.list_title, EW_GROUP_VERTICAL); list_thumbs = ew_textlist_new(NULL, 320, 140, 20, 90); =================================================================== RCS file: /cvs/e/e17/proto/entrance_edit_gui/src/gui/layout.c,v retrieving revision 1.3 retrieving revision 1.4 diff -u -3 -r1.3 -r1.4 --- layout.c 13 Aug 2006 17:00:15 -0000 1.3 +++ layout.c 14 Aug 2006 17:08:55 -0000 1.4 @@ -3,10 +3,6 @@ void egui_layout_dialog_show() { - Entrance_Notice en = ew_notice_new(ENTRANCE_NOTICE_MESSAGE_DIALOG, "notice", "This is a message", NULL); - if(en) { - ew_notice_ok_button_add(en, NULL); - ew_notice_show(en); - } + ew_messagebox_ok("notice", "This is a message", EW_MESSAGEBOX_ICON_MESSAGE); } =================================================================== RCS file: /cvs/e/e17/proto/entrance_edit_gui/src/gui/main.c,v retrieving revision 1.6 retrieving revision 1.7 diff -u -3 -r1.6 -r1.7 --- main.c 13 Aug 2006 06:17:27 -0000 1.6 +++ main.c 14 Aug 2006 17:08:55 -0000 1.7 @@ -4,7 +4,7 @@ #include "config.h" static void _main_dialog_show(void); -static void _close_button_cb(void *, void *); +static void _close_button_cb(void *, int, void *); static Entrance_Dialog dialog; @@ -38,7 +38,7 @@ ew_edjelist_add(tree, _("Sessions"),edjefile, "icons/main/sessions", NULL, 0, egui_sessions_dialog_show); ew_edjelist_add(tree, _("X settings"), edjefile, "icons/main/xsettings",NULL, 0, egui_x_settings_dialog_show); - Entrance_Widget group = ew_dialog_group_add(dialog, _("Configuration")); + Entrance_Widget group = ew_dialog_group_add(dialog, _("Configuration"), EW_GROUP_VERTICAL); ew_group_add(group, tree); ew_dialog_close_button_add(dialog, _close_button_cb, NULL); @@ -47,7 +47,7 @@ } static void -_close_button_cb(void *sender, void *data) +_close_button_cb(void *sender, int response, void *data) { ew_dialog_destroy(dialog); ew_main_quit(); ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs