Enlightenment CVS committal

Author  : moom
Project : e17
Module  : libs/etk

Dir     : e17/libs/etk/src/engines/ecore_evas


Modified Files:
        ecore_evas.c 


Log Message:
* [Ecore_Evas engine] cleanup
* [FB engine] windows can now be closed
* [Signal] There is a big design problem with accumulators. This code 
fixes it if the callbacks returns an Etk_Bool but this might not work 
for another return-type...


===================================================================
RCS file: /cvs/e/e17/libs/etk/src/engines/ecore_evas/ecore_evas.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -3 -r1.15 -r1.16
--- ecore_evas.c        12 Jan 2007 02:53:55 -0000      1.15
+++ ecore_evas.c        13 Jan 2007 19:29:19 -0000      1.16
@@ -472,8 +472,7 @@
    
    if (!(window = ETK_WINDOW(ecore_evas_data_get(ecore_evas, 
"_Etk_Engine::Window"))))
      return;
-   /* TODO: why use a func pointer here? */
-   window->move_cb(window);
+   etk_signal_emit_by_name("move", ETK_OBJECT(window), NULL);
 }
 
 /* Called when the window is resized */
@@ -487,8 +486,9 @@
    
    engine_data = window->engine_data;
    ecore_evas_geometry_get(ecore_evas, NULL, NULL, &engine_data->width, 
&engine_data->height);
-   /* TODO: why use a func pointer here? */
-   window->resize_cb(window);
+   
+   etk_signal_emit_by_name("resize", ETK_OBJECT(window), NULL);
+   etk_widget_redraw_queue(ETK_WIDGET(window)); 
 }
 
 /* Called when the window is focused in */
@@ -498,8 +498,9 @@
    
    if (!(window = ETK_WINDOW(ecore_evas_data_get(ecore_evas, 
"_Etk_Engine::Window"))))
      return;
-   /* TODO: why use a func pointer here? We may just notify the "focused" 
property */
-   window->focus_in_cb(window);
+   
+   etk_signal_emit_by_name("focus_in", ETK_OBJECT(window), NULL);
+   etk_object_notify(ETK_OBJECT(window), "focused");
 }
 
 /* Called when the window is focused out */
@@ -509,8 +510,9 @@
    
    if (!(window = ETK_WINDOW(ecore_evas_data_get(ecore_evas, 
"_Etk_Engine::Window"))))
      return;
-   /* TODO: why use a func pointer here? We may just notify the "focused" 
property */
-   window->focus_out_cb(window);
+   
+   etk_signal_emit_by_name("focus_out", ETK_OBJECT(window), NULL);
+   etk_object_notify(ETK_OBJECT(window), "focused");
 }
 
 /* Called when the window's sticky setting has changed */
@@ -520,8 +522,7 @@
    
    if (!(window = ETK_WINDOW(ecore_evas_data_get(ecore_evas, 
"_Etk_Engine::Window"))))
      return;
-   /* TODO: why use a func pointer here? We may just notify the "sticky" 
property */
-   window->sticky_changed_cb(window);
+   etk_object_notify(ETK_OBJECT(window), "sticky");
 }
 
 /* Called when the user wants to close the window */
@@ -531,6 +532,5 @@
    
    if (!(window = ETK_WINDOW(ecore_evas_data_get(ecore_evas, 
"_Etk_Engine::Window"))))
      return;
-   /* TODO: why use a func pointer here? */
-   window->delete_request_cb(window);   
+   etk_window_delete_request(window); 
 }



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs

Reply via email to