Enlightenment CVS committal
Author : barbieri
Project : e17
Module : apps/e
Dir : e17/apps/e/src/bin
Modified Files:
e_gadcon_popup.c
Log Message:
Avoid invalid read, remove useless calls.
e_object_del(E_OBJECT(pop->win)) will call ecore_evas_free() which
calls evas_free() which deletes all the objects, making pop->o_bg a
invalid read in its evas_object_del(). So it must be reordered, even
better the evas_object_del(pop->o_bg) can be avoided.
Since the window is deleted, no need to e_gadcon_popup_toggle_pinned()
it.
PS: need to check if there are users of o_con, if not, it should be
removed too.
===================================================================
RCS file: /cvs/e/e17/apps/e/src/bin/e_gadcon_popup.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -3 -r1.9 -r1.10
--- e_gadcon_popup.c 8 Jan 2008 19:33:48 -0000 1.9
+++ e_gadcon_popup.c 5 Feb 2008 16:33:24 -0000 1.10
@@ -175,9 +175,7 @@
_e_gadcon_popup_free(E_Gadcon_Popup *pop)
{
pop->gcc = NULL;
- e_object_del(E_OBJECT(pop->win));
- if (pop->pinned) e_gadcon_popup_toggle_pinned(pop);
- if (pop->o_bg) evas_object_del(pop->o_bg);
if (pop->o_con) evas_object_del(pop->o_con);
+ e_object_del(E_OBJECT(pop->win));
free(pop);
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
