Enlightenment CVS committal Author : mej Project : eterm Module : Eterm
Dir : eterm/Eterm Modified Files: ChangeLog Eterm.spec configure.in Log Message: Wed May 14 12:42:51 2008 Michael Jennings (mej) Patch from Kim Woelders <[EMAIL PROTECTED]>: There is a race problem with Eterm during startup related to the shell LINES/COLUMNS env vars. If the WM changes the window size (e.g. due to saved settings) before mapping the window, sometimes the shell will set LINES and COLUMNS according to the old/incorrect size and sometimes to the new/correct size, depending on wheter the call to tt_winsize() at command.c line 2322 (by the shell child process) or the tt_resize() (by the Eterm process) due to the ConfigureNotify caused by the resize (or WM ICCCM ConfigureNotify) operation happens first. The call in question was added by Azundris for Escreen. So far Escreen seems to be behaving properly with this patch applied, but all my Eterm windows (Escreen and otherwise) are pre-sized with -g anyway. So I'm going to keep my eye on it for awhile. In case of trouble, change the "#if 0" to "#ifdef ESCREEN" to revert to previous behavior when in Escreen mode. Normal operation should not require the call in question. ---------------------------------------------------------------------- =================================================================== RCS file: /cvs/e/eterm/Eterm/ChangeLog,v retrieving revision 1.445 retrieving revision 1.446 diff -u -3 -r1.445 -r1.446 --- ChangeLog 4 Jul 2007 00:49:32 -0000 1.445 +++ ChangeLog 14 May 2008 19:49:22 -0000 1.446 @@ -5531,3 +5531,27 @@ Remove some cruft from kEsetroot. ---------------------------------------------------------------------- +Wed May 14 12:42:51 2008 Michael Jennings (mej) + +Patch from Kim Woelders <[EMAIL PROTECTED]>: + + There is a race problem with Eterm during startup related to the + shell LINES/COLUMNS env vars. + + If the WM changes the window size (e.g. due to saved settings) + before mapping the window, sometimes the shell will set LINES and + COLUMNS according to the old/incorrect size and sometimes to the + new/correct size, depending on wheter the call to tt_winsize() at + command.c line 2322 (by the shell child process) or the + tt_resize() (by the Eterm process) due to the ConfigureNotify + caused by the resize (or WM ICCCM ConfigureNotify) operation + happens first. + +The call in question was added by Azundris for Escreen. So far +Escreen seems to be behaving properly with this patch applied, but all +my Eterm windows (Escreen and otherwise) are pre-sized with -g anyway. +So I'm going to keep my eye on it for awhile. In case of trouble, +change the "#if 0" to "#ifdef ESCREEN" to revert to previous behavior +when in Escreen mode. Normal operation should not require the call in +question. +---------------------------------------------------------------------- =================================================================== RCS file: /cvs/e/eterm/Eterm/Eterm.spec,v retrieving revision 1.21 retrieving revision 1.22 diff -u -3 -r1.21 -r1.22 --- Eterm.spec 16 Sep 2006 04:51:52 -0000 1.21 +++ Eterm.spec 14 May 2008 19:49:22 -0000 1.22 @@ -9,18 +9,18 @@ Summary: Enlightened terminal emulator Name: Eterm -Version: 0.9.4 -Release: 1 -#Release: 0.%(date '+%Y%m%d') +Version: 0.9.5 +#Release: 1 +Release: 0.%(date '+%Y%m%d') License: BSD Group: User Interface/X Requires: imlib2, imlib2-loader_jpeg, imlib2-loader_png -#BuildSuggests: xorg-x11-devel -BuildRequires: libast imlib2-devel XFree86-devel -Source0: ftp://ftp.eterm.org/pub/Eterm/%{name}-%{version}.tar.%{compression} -Source1: ftp://ftp.eterm.org/pub/Eterm/%{name}-bg-%{version}.tar.%{compression} +#BuildSuggests: xorg-x11-devel XFree86-devel xorg-x11-proto-devel libXext-devel libXt-devel freetype-devel +BuildRequires: libast imlib2-devel +Source0: http://www.eterm.org/download/%{name}-%{version}.tar.%{compression} +Source1: http://www.eterm.org/download/%{name}-bg-%{version}.tar.%{compression} URL: http://www.eterm.org/ -BuildRoot: /var/tmp/%{name}-%{version}-root +BuildRoot: %{?_tmppath}%{!?_tmppath:/var/tmp}/%{name}-%{version}-root %description Eterm is a color vt102 terminal emulator with enhanced graphical @@ -47,21 +47,21 @@ %{__make} %{?mflags} %install -rm -rf $RPM_BUILD_ROOT +%{__rm} -rf $RPM_BUILD_ROOT # If the configure macro is used above (which it is), there # is NO reason to use the makeinstall macro here, so don't. %{__make} install DESTDIR=$RPM_BUILD_ROOT %{?mflags_install} ( cd $RPM_BUILD_ROOT - mv .%{_bindir}/%{name} .%{_bindir}/%{name}-%{version} + %{__mv} .%{_bindir}/%{name} .%{_bindir}/%{name}-%{version} cd $RPM_BUILD_ROOT%{_bindir} - ln -f -s %{name}-%{version} %{name} + %{__ln_s} -f %{name}-%{version} %{name} cd $RPM_BUILD_ROOT chmod +x .%{_libdir}/lib*so* ||: ) -mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/X11/applnk/Utilities +%{__mkdir_p} $RPM_BUILD_ROOT%{_sysconfdir}/X11/applnk/Utilities cat > $RPM_BUILD_ROOT%{_sysconfdir}/X11/applnk/Utilities/Eterm.desktop <<EOF [Desktop Entry] Name=Eterm =================================================================== RCS file: /cvs/e/eterm/Eterm/configure.in,v retrieving revision 1.95 retrieving revision 1.96 diff -u -3 -r1.95 -r1.96 --- configure.in 21 Feb 2007 02:36:24 -0000 1.95 +++ configure.in 14 May 2008 19:49:22 -0000 1.96 @@ -1,4 +1,4 @@ -dnl# $Id: configure.in,v 1.95 2007/02/21 02:36:24 vapier Exp $ +dnl# $Id: configure.in,v 1.96 2008/05/14 19:49:22 mej Exp $ PATH=$PATH:/usr/bin:/bin:/usr/local/bin:/usr/ccs/bin:/usr/contrib/bin:/usr/ucb/bin export PATH @@ -22,7 +22,7 @@ SAVE_AUTOMAKE="$AUTOMAKE" AC_INIT(src/feature.h) -AM_INIT_AUTOMAKE(Eterm, 0.9.4) +AM_INIT_AUTOMAKE(Eterm, 0.9.5) dnl# Set some basic variables DATE="`date '+%d %B %Y'`" ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs