i've noticed that the Makefile in src/themes utilizes the $USER variable for chowning the themes files ...As non-root, doing "chown -R root <anything>" will fail.
Makefile.am: if [ -n "$(USER)" ]; then chown -R $(USER) $(DESTDIR)$(ethemedir); else chown -R root $(DESTDIR)$(ethemedir); fi
any particular reason ? the trouble i see is that if the user is building the
e16 pkg as a non-root user (for obvious reasons) and then goes to install it into a temporary directory before su-ing to root and doing the final install to /, the permissions may be a little messed ...
imho it should just be a chown -R root $(DESTDIR)$(ethemedir) w/out any checks against the $USER variable ... after all, why are the themes special ? none of the other subsections of e16 do this ...
The themes *are* special. They are unpacked from tarballs, and if root does that the U/GID's are preserved, so we have to set them as we want them.
I don't think there is much point in doing the "chown -R" as a non-root user, but the construction does avoid having to figure out wheter or not we are root in some other way.
I don't quite follow the normal user temporary install thing. Are you saying that # make install behaves differently after doing $ make install DESTDIR=$PWD/test
The only trouble I see after doing "make install" as root is that the theme file group ID's are not root.
Maybe we should do:
if [ "$USER" = "root" -o "$USER" = "" ]; then \
chown -R root $(DESTDIR)$(ethemedir); \
chgrp -R root $(DESTDIR)$(ethemedir); \
fi
/Kim
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
