On Sat, 13 Mar 2004 15:11:14 -0500 Jose O Gonzalez <[EMAIL PROTECTED]> babbled:
>
> What follows is the first in a series of patches
> designed to speed up some of Evas' drawing/blending
> C functions in the "engines/common" dir.
>
> As later patches will involve non-trivial changes,
> this first *very small* one is merely to fix a minor oversight
> and add a trivial check in the line drawing function of the
> file "evas_line_main.c".
this in theory helps - but in practice doesn't because the canvas object
routines remove the draw opt higher up as it knows the whole object is
transparent/invisible and even avoids other side-effect draws like convert from
RGBA to screen depth and expose/damage redraws for a line that has changed, but
is invisible :)
> One question though: Is there a reason for not using
> say Imlib2's anti-aliased line drawing algorithm here?
it has accuracy issues when being clipped. i decided to "keep it simple" and
deal with AA lines later when handling "thick lines" and anti-aliases polygons
etc. - but i have never gotten to that yet :)
> jose.
>
> ----------------------------------------------------------------
>
>
> Index: cvs/e17/libs/evas/src/lib/engines/common/evas_line_main.c
> ===================================================================
> RCS file:
> /cvsroot/enlightenment/e17/libs/evas/src/lib/engines/common/evas_line_mai
> n.c,v
> retrieving revision 1.4
> diff -u -r1.4 evas_line_main.c
> --- cvs/e17/libs/evas/src/lib/engines/common/evas_line_main.c 26 Jan 2004
> 03:31:39 -0000 1.4
> +++ cvs/e17/libs/evas/src/lib/engines/common/evas_line_main.c 15 Mar 2004
> 07:46:22 -0000
> @@ -31,6 +31,9 @@
> sx = SGN(dx);
> sy = SGN(dy);
>
> + col = dc->col.col;
> + if (!A_VAL(&(col))) return;
> +
> if ((dx == 0) && (dy == 0))
> {
> if ((x1 < 0) ||
> @@ -86,7 +89,6 @@
> im = dst->image->data;
> im_w = dst->image->w;
> im_h = dst->image->h;
> - col = dc->col.col;
>
> ext_x = 0; ext_y = 0; ext_w = im_w; ext_h = im_h;
> if (dc->clip.use)
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> enlightenment-devel mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [EMAIL PROTECTED]
熊耳 - 車君 (数田) [EMAIL PROTECTED]
Tokyo, Japan (東京 日本)
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
enlightenment-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
