On Wed, May 26, 2004 at 12:21:57AM +0200, Kim Woelders wrote: > Jaron Omega wrote: > >Hi everybody! > > > > Here's a patch I have been working on for the past week, and that > >I think other E users might appreciate. It's against E 16.7-0.60 > >(pre2). What it does is allow you to keep parts of the GUI opaque > >when using translucency (thanks imlib2).
> Thanks! > I'd like this included. However, in particular one change is required: > You adjust the applied ImageClass opacity using a flags field in the > ImageClass struct. As you have probably discovered the ImageClass'es are > referenced from many different objects and therefore you have to set and > clear these flags all the time. > The big problem with this is that sometimes the "application" of the > ImageClass is deferred (and may even be dropped) via the draw queue > mechanism. The flags field may therefore not have the desired value by > the time the ImageClass gets applied to the object. This causes visible > "glitches". I will work on this. I think this might take care of some problems I have seen with modifying settings on the fly. > You will have to propagate the flags via an additional parameter to > IclassApply() and IclassApplyCopy(), also propagated through the draw > queue. In my first attempt, my method was similar to your suggestion. But, I didn't mind the draw queue. I think this isn't too bad and maybe soon I'll have this implemented unless someone else does first. > You will find that this significantly simplifies the code too :) > This should make the introduced "flags" struct items unused. I'm sure. Just quickly looking at your suggestion, the propogated flags (perhaps a flags struct) can contain all the data needed about type of image, and just have one routine to query config settings accordingly. > Making the menus "aqua" transparent should be optional. > Actually, it might be nice if the menu and tooltip transparency type > could be selected between off, background, and "aqua"(?). Actually, menus being "aqua" is a hidden option, I had a problem in settings.c getting the radiobuttons to work and decided to comment out that part. Option's there already. The ToolTip transparency I implemented, just now, on my laptop; looks good. > And then the boring complaints: > - Opaque menu item highlighting doesn't seem to work in the winter > theme. I'm thinking I can take care of this when I redo my approach. > - Remove obsolete commented out stuff added by the patch. > - Don't include "non-changes" like the ones in EWinBit and the added but > unused SettingsTransparency() prototype. > - Please remove stuff that hasn't been finished like > Conf.sel_transparency.focused/unfocused/hilighted/tinted/eterm. > Maybe it can be added if implemented. I had the transparency settings in their own dialog box initially, I may return to that approach depending on how many features we can come up with. Nonetheless, I'll make sure unused code is not in my patches. > - It would help if you could make the patch based on current CVS. > - Watch out with diff's -N flag, I don't think "set.txt" should > have been included :) Oh yes, I'm embarrassed about the 'set.txt' ending up in the patch. I hope to have a new patch soon. And thanks for looking at my patch. Jaron Omega ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
