On Fri, 17 Dec 2004 15:11:43 EST, Frederick Heckel said:
> Anyway, a null check needs to be added to Engage's icon.c, in
> od_icon_mapping_get() to fix the problem. app->winclass was null. Engage
> starts up fine for me with this quick change:
>
> 358c358,359
> < if (strcmp(winclass, app->winclass) == 0) {
> ---
> >
> > if (winclass&&app->winclass&&strcmp(winclass, app->winclass) == 0)This is just begging the question however - is this: 1) A proper fix, because od_icon_mapping_get() could legitimately be called with a NULL and it should Do Something Reasonable 2) Papering over the *real* bug, which is that somebody else is failing to set winclass or app->winclass before calling the function? If it's case (2), then we're just looking at a matter of time before the *next* symptom shows up.. ;)
pgpWUu0AdGx0j.pgp
Description: PGP signature
