-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Michel Briand wrote:
| If I understand entrance is lauched by another program (entranced?)
that sets
| DISPLAY. Correct ?
|
| Thus testing DISPLAY should be a first step in main() checks. Ok. And
storing a
| strdup of getenv("DISPLAY") should be made earlier I think.
|Entranced passes the display as a command line option to entrance. This
lets you run multiple entrance-managed displays. The strdup of
getenv("DISPLAY") is in the right place. $DISPLAY isn't going to change,
and the reason why it is in the entrance_session_new() function is
because it needs to be stored in the session struct. There is no other
place to put that strdup.| What do you think of my ecore_evas_engine_type_supported_get() call ? |
It's in CVS. Thank you. :)
| IMHO testing include files is not correct in configure. I agree with Raster on | that point. |
No, it is not incorrect. You prefer the ecore-config approach, but that does not make it incorrect. It was properly thought out and works very well. Think of this: you can't assume that all ecore installations will be feature complete. Ecore-config is a simpler, easier way out, but it's not necessarily better than what's there. If I just used "ecore-config - --includes" and for some whacked reason joe user didn't install ecore_ipc, then the error occurs during compilation instead of at configure stage. And it's much uglier.
| Another topic: how do you start another server on a machine that
already have an
| X running at :0.0 ? To test entrance I like to start another server with
|
| xinit ${e17path}/sbin/entranced -- X :1
|Wrong wrong wrong. Entranced launches the X session - you do not need xinit at all.
entranced -d :1
Simplify. :)
| ps: I'll use diff -u, promiss! |
Thanks, much appreciated. :)
| Michel | | Ibukun Olumuyiwa a �crit : | |>>Actually, if the DISPLAY variable is not set entrance doesn't even |>>start, so it wouldn't even get this far (it would have failed at |>>ecore_evas_software_x11_new()). So I'd say adding a fallback would be |>>redundant at this point. |>> |>>And yes Michel, please next time send diffs using -u :) |>> |>>Corey Donohoe wrote: |>>| We should have an else condition to the getenv check, if e->display is |>>NULL |>>| pam authentication is going to fail miserably. We also prefer 'diff -u' |>>| format :D |>>| |>>| * Michel Briand ([EMAIL PROTECTED]) wrote: |>>| |>>|>-----BEGIN PGP SIGNED MESSAGE----- |>>|>Hash: SHA1 |>>|> |>>|>Hello Ibukun |>>|> |>>|>please chech these files: |>>|> |>>|> entrance_session.c: fix a segfault when DISPLAY=(null) |>>|> |>>|>Index: src/client/entrance_session.c |>>|>=================================================================== |>>|>RCS file: |>>/cvsroot/enlightenment/e17/apps/entrance/src/client/entrance_session.c,v |>>|>retrieving revision 1.67 |>>|>diff -r1.67 entrance_session.c |>>|>38c38 |>>|>< char *db; |>>|>--- |>>|> |>>|>> char *db, *str; |>>|> |>>|>49,51c49,51 |>>|>< if (!display) |>>|>< e->display = strdup(getenv("DISPLAY")); |>>|>< else |>>|>--- |>>|> |>>|>> if (!display) { |>>|>> if ((str = getenv("DISPLAY"))) e->display = strdup(str); |>>|>> } else |>>| |>>| |>>| __ |>>| Corey Donohoe |>>| http://www.atmos.org |>>| |>>| |>>| ------------------------------------------------------- |>>| SF email is sponsored by - The IT Product Guide |>>| Read honest & candid reviews on hundreds of IT Products from real users. |>>| Discover which products truly live up to the hype. Start reading now. |>>| http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click |>>| _______________________________________________ |>>| enlightenment-devel mailing list |>>| [email protected] |>>| https://lists.sourceforge.net/lists/listinfo/enlightenment-devel |>> |>> |>>-- |>> |>>Ibukun Olumuyiwa |>>http://xcomputerman.com |>> |>>"I will stand upon my watch, and set me upon the tower, |>>and will watch to see what he will say unto me, |>>and what I shall answer when I am reproved." |>> | | | ------------------------------------------------------- | SF email is sponsored by - The IT Product Guide | Read honest & candid reviews on hundreds of IT Products from real users. | Discover which products truly live up to the hype. Start reading now. | http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click | _______________________________________________ | enlightenment-devel mailing list | [email protected] | https://lists.sourceforge.net/lists/listinfo/enlightenment-devel | |
- --
Ibukun Olumuyiwa http://xcomputerman.com
"I will stand upon my watch, and set me upon the tower, and will watch to see what he will say unto me, and what I shall answer when I am reproved."
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCMW+zImU2r6Etn78RAiRhAKDcenAiLKw4fHVVCuRdMagTG6SGHgCfU5K/ Xi/287TkuEOlcVmPjsfUDKY= =Ii99 -----END PGP SIGNATURE-----
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
