* Piotr Skamruk, ([EMAIL PROTECTED]) napisał:
> ...
later in code (:
1. in ecore_list_nodes ret is initialized to some, but later it isn't used
(CHECK_ fail...) or is set to other value...
2. in ecore_list_append declaration of ret is unnessesary, value returned
by _ecore_list_append_0 should be returned directly
3. ecore_list_(insert|goto|current|remove|next|for_each), same as in 2.
4. _ecore_list_remove_(0|first|last), same as in 1.
5. ecore_list_goto_(index|first|last), same as in 2.
6. in ecore_dlist_insert:
if (!ret) {
return ret;
}
better would be:
if (!ret) return NULL;
7. ecore_dlist_(remove|goto|current|next|previous), same as in 2.
8. same in ecore_dlist_goto_(index|first|last)
9. same in ecore_dlist_remove_last
10. _ecore_dlist_previous, same as in 1.
something else? :)
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
