Michael Jennings wrote:
On Wednesday, 20 April 2005, at 08:09:08 (-0700),
E CVS List wrote:


use an install hook to setuid freqset thus avoiding mkinstalldir issues with 
diff versions of automake
===================================================================
RCS file: /cvsroot/enlightenment/e17/apps/e/src/modules/cpufreq/Makefile.am,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -3 -r1.7 -r1.8
--- Makefile.am 20 Apr 2005 14:51:37 -0000      1.7
+++ Makefile.am 20 Apr 2005 15:09:08 -0000      1.8
@@ -5,9 +5,6 @@
filesdir = $(libdir)/enlightenment/modules/$(MODULE)
files_DATA = \
module_icon.png
-freqsetdir = $(libdir)/enlightenment/modules/$(MODULE)
-freqset_DATA = \
-freqset$(EXEEXT)

EXTRA_DIST = $(files_DATA)

@@ -28,16 +25,13 @@
module_la_LDFLAGS      = -module -avoid-version
module_la_DEPENDENCIES = $(top_builddir)/config.h

-all-local: freqset$(EXEEXT)
+freqsetdir = $(pkgdir)
+freqset_DATA = \
+freqset$(EXEEXT)
setuid_root_mode = a=rx,u+s

-INSTALL_SU = \
-  test -z "$(pkgdir)" || $(MKINSTALLDIRS) "$(DESTDIR)$(pkgdir)"; \
-  echo "$(INSTALL_PROGRAM_ENV) $(LIBTOOL) --mode=install $(INSTALL) -m 
$(setuid_root_mode) freqset$(EXEEXT) $(DESTDIR)$(pkgdir)/freqset$(EXEEXT)"; \
-  $(INSTALL_PROGRAM_ENV) $(LIBTOOL) --mode=install $(INSTALL) -m 
$(setuid_root_mode) freqset$(EXEEXT) $(DESTDIR)$(pkgdir)/freqset$(EXEEXT);
-
-install-freqsetDATA: freqset$(EXEEXT)
-       @$(INSTALL_SU)
+install-data-hook:
+       @chmod $(setuid_root_mode) $(DESTDIR)$(freqsetdir)/freqset$(EXEEXT)


I think you want a - sign, not an @ sign, there.  @ sign only
suppresses output.  You need the - to make sure failure of that line
doesn't halt the build.

Michael


Hello !

Another way to get that corrected is to modify MKINSTALLDIRS from $(top_builddir)/./mkinstalldirs to $(mkinstalldirs), which contains $(install_sh) -d, in makefiles.
It works atleast for me ;)


 Cheers.


ilLogict


------------------------------------------------------- This SF.Net email is sponsored by: New Crystal Reports XI. Version 11 adds new functionality designed to reduce time involved in creating, integrating, and deploying reporting solutions. Free runtime info, new features, or free trial, at: http://www.businessobjects.com/devxi/728 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to