On Thursday 21 April 2005 05:08 pm, Michael Jennings wrote: > On Wednesday, 20 April 2005, at 19:05:18 (-0400), > Mike Frysinger wrote: > > windows.c and screen.c look fine, but pixmap.c looks a little fishy: > > XChangeProperty(Xdisplay, TermWin.parent, > > props[PROP_EWMH_ICON], XA_CARDINAL, 32, PropModeReplace, > > (unsigned char *) icon_data, sizeof(icon_data) / > > sizeof(CARD32)); i dont really know anything about X functions, so you > > guys would know whether this is fine too ... > > The fix went into a header file, though, right? (I'm on a hella slow > connection right now, so I can't check myself.) :(
the patch i committed applied against src/command.h and that's it ... i was just checking other things to see if similar fixes could be used elsewhere and i noticed pixmap.c ... so i'm asking for someone else to verify that this code is 32bit/64bit clean since i know nothing of X functions > On Wednesday, 20 April 2005, at 21:47:28 (-0400), > Mike Frysinger wrote: > > Roland B=E4r submitted this patch: > > http://bugs.gentoo.org/attachment.cgi?id=3D52947&action=3Dview > > via this bug: > > http://bugs.gentoo.org/show_bug.cgi?id=3D84520 > > > > in an attempt to get the code working for amd64 ... patch is not ok as > > is, = but=20 > > if the x86-specific code is wrapped in #ifdef __i386__ and then amd64 > > code = is=20 > > wrapped in #ifdef __x86_64__, this shoud be ok to commit ? > > My policy: Test it on i386. If it doesn't break that, commit it, > because that's all I have to test with and can't yell at you if it > Works For Me(tm). *grin* > > Your approach sounds fine. I always watch commits to make sure the > patches that go in are acceptable, so don't worry about "sneaking one > past the goalie." ok, i'll clean it up and commit it -mike ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
