This was actually my patch but vapier (Mike Frysinger) submitted it through Gentoo for me. It is not a 64/32 bit thing so much as it is a 32 bits/pixel thing. I'm not as familiar with the code as I'd like to be but this code snippet seems hard coded for 32bpp. Has this been tried using other color depths? If icon_data is a pointer to a 16bpp image and we divide it by CARD32 won't the nelements parameter be half of what it should be?
Just asking. :-) On Tue, 2005-04-26 at 13:26 -0400, Michael Jennings wrote: > On Thursday, 21 April 2005, at 18:17:26 (-0400), > Mike Frysinger wrote: > > > the patch i committed applied against src/command.h and that's it > > ... i was just checking other things to see if similar fixes could > > be used elsewhere and i noticed pixmap.c ... so i'm asking for > > someone else to verify that this code is 32bit/64bit clean since i > > know nothing of X functions > > Your patch did not change the definition of CARD32. It is still 32 > bits. Rather, it changed the structure for MWM hints to use CARD64 > and INT64 instead of CARD32 and INT32. > > Michael > -- Tres ------------------------------------------------------- SF.Net email is sponsored by: Tell us your software development plans! Take this survey and enter to win a one-year sub to SourceForge.net Plus IDC's 2005 look-ahead and a copy of this survey Click here to start! http://www.idcswdc.com/cgi-bin/survey?id=105hix _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
