Vincent Torri wrote:

On Fri, 10 Jun 2005, Sebastian Dransfeld wrote:


Vincent Torri wrote:

seb,

line 294, are you sure that you want to test is the result of

  if (!XGetWMNormalHints(_ecore_x_disp, win, &hint, &mask))

is false ?

The XGetWMNormalHints function returns the size hints stored in the
  WM_NORMAL_HINTS property on the specified window.  If the property is
      of type WM_SIZE_HINTS, is of format 32, and is long enough to
contain       either an old (pre-ICCCM) or new size hints structure,
XGetWMNormal-       Hints sets the various fields of the XSizeHints
structure, sets the       supplied_return argument to the list of fields
that were supplied by       the user (whether or not they contained
defined values), and returns a       nonzero status.  Otherwise, it
returns a zero status.

So, if there is an error, return 0. !0 == true, so if there is an error,
return 0.


so, what it the purpose of the code that follows ? You set them with
XGetWMNormalHints and, after that, with this code.

The user can supply 0 arguments to keep the current state. But you are right, I shouldn't return on error, because there might be no hints which returns false.

Sebastian


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy. Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to