On Wednesday, 18 May 2005, at 01:10:13 (-0600), Tres Melton wrote: > The second patch I actually recommend that you do not apply. It > does greatly speed up the instruction but costs readability. It is > only executed once per window to shade so the speedup may not be > worth it but I'll leave the decision up to you. Basically checking > that each color modifier is less than 256 is the same as checking > that no bits of 8 (starting from 0) or higher are set. Or them all > up, shift off the irrelevant bits and see what's left. You could > also check to see if all three color modifiers are equal to 256 and > blow out early if you wanted to. > if(!((rm^0x100)|(gm^0x100)|(bm^0x100)))
Both patches have been applied. I used a macro to maintain readability. > If you would like, I would be willing to maintain the shading > routines. I don't know cvs well enough to commit anything but you > can bounce anything that gets submitted off of me and I'll double > check them; I feel pretty comfortable in that code now. I tried to > adjust the auto-magic stuff for sse2 but I don't know it well enough > yet. I manually linked Eterm to use the sse routines on my machine > and they work here. Please feel free to remove all my notes from > the top of the sse2_cmod.c file and any other crap you want to > before merging it. Let me know if you want me to test the merged > code. As I do not have a P4 box or an x86_64 box, please test the latest CVS stuff to make sure nothing was merged incorrectly. Also, if you'd like to maintain the shading stuff, please do. :) > If you tell me where Eterm reads the background from e and sets its > initial geometry I'd also like to fix the problem of the pop-up > scrollbar taking up room when it is not active at startup. (I sent > you pics of the problem awhile back.) The initial window creation and sizing is done in windows.c in Create_Windows() On Monday, 06 June 2005, at 11:28:28 (-0400), John Ellson wrote: > Tres asked me to help with the configure.in and Makefile.am bits for > his SSE2 code for x86_64. I've attached patches against Eterm CVS > with changes to: configure.in, src/Makefile.am, src/pixmap.c, and > the new file: src/sse2_cmod.c (changed since Tres's earlier version) Applied. Thanks. :) > The configure.in changes add "--enable-sse2" which will be on by > default for x86_64. The incomplete tests for MMX_64 have been > removed. There was an odd "dps_snprintf_oflow()" line in > configure.in which was causing problems on my i686 system, and which > I think was a typo, so I removed it. It is not a typo. The macro is defined in libast.m4. Either you don't have libast.m4 installed properly, or you need to set ACLOCAL_FLAGS to help aclocal find it. > The src/pixman.c changes add externs for the new sse2 function, and > conditionals to use them if HAVE_SSE2 is defined. Tres also added 8 > or 16 byte alignment conditionally to colormod_trans() - this should > perhaps be done only for gcc? Hopefully someone with a Solaris box will let us know if anything broke portability-wise. (benr: HINT!) :-) > Tres indicated that adding "-mpreferred-stack-boundary=16" might > still be beneficial on x86_64, but that it might consume extra space > at run time. I'm not in a position to make that call, but if you > agree its a good idea I can probably make the configure.in change. Has anyone done any testing on this in terms of additional RSS being needed? Thanks, Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]> n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) ----------------------------------------------------------------------- "Men always want to please women, but these last 15 years, women have been hard to please. If you want to resist the feminist movement, the simple way to do it is to give them what they want, and they'll defeat themselves." -- Jack Nicholson, "Vanity Fair," April 1994 ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
