I checked out CVS last night and am compiling now, it seems ewl is still
using the PF_ prefix:
ewl_config.c: In function `ewl_config_config_read':
ewl_config.c:209: error: `PF_MODIFIED' undeclared (first use in this
function)
ewl_config.c:209: error: (Each undeclared identifier is reported only once
ewl_config.c:209: error: for each function it appears in.)
ewl_config.c:210: error: `PF_SYSTEM' undeclared (first use in this
...
I attach a patch against ewl_config.c which replaces all PF_* with
ECORE_CONFIG_FLAG_*.
Chris Ross wrote:
>
> There is a problem with Ecore Config on OS X.
>
> Within the enumerated type 'Ecore_Config_Flag':
>
> typedef enum Ecore_Config_Flag
> {
> PF_NONE = 0,
> PF_BOUNDS = 1,
> PF_MODIFIED = 2,
> PF_SYSTEM = 4,
> PF_CMDLN = 8
> } Ecore_Config_Flag;
>
> The problem is PF_SYSTEM, which, under OSX, is defined in the
> network headers to have the same value as AF_SYSTEM. This obviously
> causes the whole sheer-bang to mis-compile.
>
> Can I make a request to change the prefix from PF_ to ECF_ or EF_
> (or indeed any other prefix that is EFL related).
>
> Regards,
>
> Chris
--
Thomas C R Spurden (0xBB944725)
--- ewl_config.c.bu 2005-09-19 15:48:21.000000000 +0000
+++ ewl_config.c 2005-09-19 15:51:14.000000000 +0000
@@ -206,8 +206,8 @@ static void ewl_config_config_read(void)
cc = ewl_config_int_get("/ewl/theme/color_classes/count");
prop = ecore_config_get("/ewl/theme/color_classes/count");
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
for (i = 0; i < cc; i++) {
char *name;
@@ -217,8 +217,8 @@ static void ewl_config_config_read(void)
"/ewl/theme/color_classes/%d/name", i);
name = ewl_config_str_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
if (name) {
int r, g, b, a;
@@ -229,85 +229,85 @@ static void ewl_config_config_read(void)
"/ewl/theme/color_classes/%d/r", i);
r = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/g", i);
g = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/b", i);
b = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/a", i);
a = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/r2", i);
r2 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/g2", i);
g2 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/b2", i);
b2 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/a2", i);
a2 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/r3", i);
r3 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/g3", i);
g3 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/b3", i);
b3 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
snprintf(key, PATH_MAX,
"/ewl/theme/color_classes/%d/a3", i);
a3 = ewl_config_int_get(key);
prop = ecore_config_get(key);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
edje_color_class_set(name, r, g, b, a,
r2, g2, b2, a2,
@@ -385,8 +385,8 @@ static void ewl_config_defaults_set(void
for(i = 0; keys[i] != NULL; i++) {
prop = ecore_config_get(keys[i]);
- prop->flags &= ~PF_MODIFIED;
- prop->flags |= PF_SYSTEM;
+ prop->flags &= ~ECORE_CONFIG_FLAG_MODIFIED;
+ prop->flags |= ECORE_CONFIG_FLAG_SYSTEM;
}
ecore_config_listen("ewl_debug_enable", "/ewl/debug/enable",
