I'm curious how this situation and the negative height on the text were being triggered. In this case i->image shouldn't exist if the embed is NULL. If it doesn't exist and you cache with a NULL embed, the object gets scheduled for the GC to free.

Thanks,
Nathan

On 11/16/05, enlightenment-cvs@lists.sourceforge.net < enlightenment-cvs@lists.sourceforge.net> wrote:
Enlightenment CVS committal

Author  : lordchaos
Project : e17
Module  : libs/ewl

Dir     : e17/libs/ewl/src/lib


Modified Files:
        ewl_image.c


Log Message:
* Stop trying to cache an image's evas, if we can't find the ewl_embed it belongs to

===================================================================
RCS file: /cvsroot/enlightenment/e17/libs/ewl/src/lib/ewl_image.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -3 -r1.19 -r1.20
--- ewl_image.c 13 Nov 2005 06:48:55 -0000      1.19
+++ ewl_image.c 16 Nov 2005 07:54:59 -0000      1.20
@@ -378,7 +378,7 @@
        emb = ewl_embed_widget_find(w);

        i = EWL_IMAGE(w);
-       if (i->image) {
+       if (emb && i->image) {
                ewl_embed_object_cache(emb, i->image);
                i->image = NULL;
        }




-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs

Reply via email to