On Tue, 6 Dec 2005 14:55:50 -0800 David Sharp <[EMAIL PROTECTED]> babbled:
> On 12/6/05, Mike Frysinger <[EMAIL PROTECTED]> wrote: > > On Wed, Dec 07, 2005 at 05:27:15AM +1100, Alastair Poole wrote: > > > > > > > why pepper the source code with obvious work arounds for a tool that > > > > appears to be broken > > > > > > Whatever you feel. Personally I see valgrind as a valuable tool, and > > > although not perfect, imho, it makes the life of a developer a lot > > > easier. Should users of Evas be excluded from using valgrind? > > > > or a better idea might be to fix valgrind > > or, since i don't think this is a flaw in valgrind, just write a > suppression for it, or let valgrind write one for you: > http://valgrind.org/docs/manual/faq.html#faq.writesupp indeed - write a suppression. this patch isnt useful - as mike said - the code explicitly fills that char array immediately after your patch before every reading/using it. this is a core routine where uselessly re-setting variable values can have performance impacts you could measure (this is called every time evas needs to draw a character). valgrind is smoking some crack methinks :) it has never bitched about that to me though - so maybe its just your valgrind there - but use a suppression for it and it will go away. :) > > -mike > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > > for problems? Stop! Download the new AJAX search engine that makes > > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_idv37&alloc_id865&opÌk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
