While I was bringing ecore_exe fork'n'pipe into consistency with ecore_con and ecore_ipc, I noticed a problem with the way the exe event types are allocated and named. To make them more consistent, ECORE_EVENT_EXE_EXIT and ECORE_EVENT_EXE_DATA should be renamed to ECORE_EXE_EVENT_DEL and ECORE_EXE_EVENT_DATA, then be allocated with ecore_event_type_new(). An ECORE_EXE_EVENT_ADD should be added as well.
ECORE_EVENT_EXE_EXIT is historical, before there where plans to add fork'n'pipe style IPC to ecore_exe. raster was probably not thinking of consistency when he named all the ecore_exe fork'n'pipe stuff. I think consistency is a good idea for this though. Stuff that will need to be updated if I change ECORE_EVENT_EXE_EXIT - misc/engage e_modules/mount e_modules/screenshot e17/proto/exhibit e17/apps/entrance e17/apps/e evidence also uses ECORE_EVENT_EXE_EXIT, and that is a problem as I don't think anybody that is still active has cvs write permission for evidence. Has evidence been broken by any API changes since it went quiet? I don't want to be the first. The rest of my fork'n'pipe consistency work is unlikely to bother anyone, as no one else uses it yet. Although devilhorns tells me he will use it today. So, the question is - Should I change ECORE_EVENT_EXE_EXIT for consistency, or leave it as is for historical reasons? At the very least I could set up an alias, and deprecate use of the original.
pgpwn8cVXguMl.pgp
Description: PGP signature
